Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3635] remove log4j dependency in client pom #3636

Merged

Conversation

Zanglei06
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

log4j is not used in rocketmq-client, it is better to remove it to avoid security scans.

Brief changelog

remove log4j dependency in client pom

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 56.194% when pulling 56b9447 on Zanglei06:remove_client_log4j_dependency_dev into 7d1b001 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3636 (56b9447) into develop (50d45f2) will increase coverage by 0.87%.
The diff coverage is 47.88%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3636      +/-   ##
=============================================
+ Coverage      48.86%   49.74%   +0.87%     
- Complexity      4659     4730      +71     
=============================================
  Files            555      555              
  Lines          36726    36770      +44     
  Branches        4840     4847       +7     
=============================================
+ Hits           17946    18290     +344     
+ Misses         16532    16192     -340     
- Partials        2248     2288      +40     
Impacted Files Coverage Δ
...cketmq/broker/filter/MessageEvaluationContext.java 30.76% <0.00%> (ø)
...tmq/broker/longpolling/PullRequestHoldService.java 20.48% <0.00%> (ø)
...ocketmq/client/consumer/DefaultMQPushConsumer.java 56.43% <0.00%> (+0.49%) ⬆️
...mq/client/consumer/store/LocalFileOffsetStore.java 56.31% <0.00%> (-0.56%) ⬇️
.../rocketmq/client/impl/ClientRemotingProcessor.java 2.91% <0.00%> (ø)
...java/org/apache/rocketmq/common/Configuration.java 0.00% <0.00%> (ø)
...n/java/org/apache/rocketmq/test/util/FileUtil.java 0.00% <0.00%> (ø)
...in/java/org/apache/rocketmq/test/util/MQAdmin.java 38.88% <0.00%> (ø)
...mq/client/impl/producer/DefaultMQProducerImpl.java 46.05% <40.00%> (-0.14%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <87.50%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b58328...56b9447. Read the comment docs.

@areyouok areyouok merged commit 4a8263b into apache:develop Dec 13, 2021
@duhenglucky duhenglucky linked an issue Dec 13, 2021 that may be closed by this pull request
devfat pushed a commit to devfat/rocketmq that referenced this pull request Mar 3, 2022
Co-authored-by: zanglei <zanglei@kuaishou.com>
cserwen pushed a commit to cserwen/rocketmq that referenced this pull request Apr 2, 2022
Co-authored-by: zanglei <zanglei@kuaishou.com>
Conflicts:
	client/pom.xml
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Co-authored-by: zanglei <zanglei@kuaishou.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove unused test scope log4j dependency for rocketmq-client
7 participants