Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ACL function：when acl and message trace is both enabled and the topic RMQ_SYS_TRACE_TOPIC is used for message trace, user doesn't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC to acl config #3942

Closed
sunxi92 opened this issue Mar 8, 2022 · 0 comments
Closed

Improve ACL function：when acl and message trace is both enabled and the topic RMQ_SYS_TRACE_TOPIC is used for message trace, user doesn't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC to acl config #3942

sunxi92 opened this issue Mar 8, 2022 · 0 comments
Labels
module/acl type/enhancement
Milestone
4.9.4

Comments

@sunxi92
Copy link
Contributor

sunxi92 commented Mar 8, 2022

The issue tracker is used for bug reporting purposes ONLY whereas feature request needs to follow the RIP process. To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.

It is recommended to start a discussion thread in the mailing lists in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.

Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.

Generally, fixing an issue goes through the following steps:

  1. Understand the issue reported;
  2. Reproduce the unexpected behavior locally;
  3. Perform root cause analysis to identify the underlying problem;
  4. Create test cases to cover the identified problem;
  5. Work out a solution to rectify the behavior and make the newly created test cases pass;
  6. Make a pull request and go through peer review;

As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:

BUG REPORT

  1. Please describe the issue you observed:

  • What did you do (The steps to reproduce)?

  • What is expected to see?

  • What did you see instead?

  1. Please tell us about your environment:

  2. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):

FEATURE REQUEST

  1. Please describe the feature you are requesting.

  2. Provide any additional detail on your proposed use case for this feature.

  3. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

  4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:
@sunxi92 sunxi92 mentioned this issue Mar 8, 2022
Merged
6 tasks
@duhenglucky duhenglucky added this to the 4.9.4 milestone Mar 9, 2022
duhenglucky pushed a commit that referenced this issue Mar 15, 2022
@sunxi92
[#3942]If both acl and message trace are enabled and the default topi…
c1aeca2 
…c RMQ_SYS_TRACE_TOPIC is used for message trace, you don't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC topic to the acl config. (#3943)

* If both acl and message trace are enabled and the default topic RMQ_SYS_TRACE_TOPIC is used for message trace, you don't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC topic to the acl config.

* Delete Chinese character in comments.
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this issue Aug 12, 2022
@sunxi92
[apache#3942]If both acl and message trace are enabled and the defaul…
ff9d8e4 
…t topic RMQ_SYS_TRACE_TOPIC is used for message trace, you don't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC topic to the acl config. (apache#3943)

* If both acl and message trace are enabled and the default topic RMQ_SYS_TRACE_TOPIC is used for message trace, you don't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC topic to the acl config.

* Delete Chinese character in comments.
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this issue Sep 10, 2024
@sunxi92
[apache#3942]If both acl and message trace are enabled and the defaul…
669b35d 
…t topic RMQ_SYS_TRACE_TOPIC is used for message trace, you don't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC topic to the acl config. (apache#3943)

* If both acl and message trace are enabled and the default topic RMQ_SYS_TRACE_TOPIC is used for message trace, you don't need to add the PUB permission of RMQ_SYS_TRACE_TOPIC topic to the acl config.

* Delete Chinese character in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/acl type/enhancement
Projects
None yet
Milestone
4.9.4
Development

No branches or pull requests
2 participants
@duhenglucky @sunxi92