Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RebalanceImpl：Reduce redundant for loops #5151

Closed
CLFutureX opened this issue Sep 21, 2022 · 0 comments · Fixed by #5154
Closed

RebalanceImpl：Reduce redundant for loops #5151

CLFutureX opened this issue Sep 21, 2022 · 0 comments · Fixed by #5154
Labels
module/client type/code style

Comments

@CLFutureX
Copy link
Contributor

CLFutureX commented Sep 21, 2022 •
edited
Loading

When the transaction message processes the locking result, the two for loops can be combined into one to reduce redundant for loops.
package org.apache.rocketmq.client.impl.consumer;
image

For example, it can be modified like this：
image
@CLFutureX CLFutureX changed the title Reduce redundant for loops RebalanceImpl：Reduce redundant for loops Sep 21, 2022
CLFutureX pushed a commit to CLFutureX/rocketmq that referenced this issue Sep 21, 2022
[ISSUE apache#5151]Reduce redundant for loops
dce5265
@HScarb HScarb linked a pull request Sep 22, 2022 that will close this issue
[ISSUE #5151]Reduce redundant for loops #5154
Merged
6 tasks
CLFutureX pushed a commit to CLFutureX/rocketmq that referenced this issue Sep 22, 2022
[ISSUE apache#5151] code re-format
c32611e
lizhanhui pushed a commit that referenced this issue Sep 23, 2022
@CLFutureX
[ISSUE #5151]Reduce redundant for loops (#5154)
590a680 
* [ISSUE #5151]Reduce redundant for loops

* [ISSUE #5151] code re-format

Co-authored-by: chenyong <chenyong@highlight.mobi>
drpmma pushed a commit that referenced this issue Feb 21, 2023
@CLFutureX @drpmma
[ISSUE #5151]Reduce redundant for loops (#5154)
c9908be 
* [ISSUE #5151]Reduce redundant for loops

* [ISSUE #5151] code re-format

Co-authored-by: chenyong <chenyong@highlight.mobi>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module/client type/code style
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #5151]Reduce redundant for loops CLFutureX/rocketmq
2 participants
@HScarb @CLFutureX