Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The retry messages should not be decompressed in PopReviveService #5402

Closed
xdkxlk opened this issue Oct 26, 2022 · 0 comments · Fixed by #5403
Closed

The retry messages should not be decompressed in PopReviveService #5402

xdkxlk opened this issue Oct 26, 2022 · 0 comments · Fixed by #5403

Comments

@xdkxlk
Copy link
Contributor

xdkxlk commented Oct 26, 2022

The steps to reproduce

  1. Send a large message
  2. Pop this message from broker but not ack

We will see, the large message will be decompressed in PopReviveService
And this will lead to the decompressed message maybe cannot put into MessageStore, because the size of the message may exceed the maxMessageSize
xdkxlk added a commit to xdkxlk/rocketmq that referenced this issue Oct 26, 2022
@xdkxlk
[ISSUE apache#5402] not to decompress the messageBody when get retry …
d29c253 
…messages in PopReviveService
@xdkxlk xdkxlk mentioned this issue Oct 26, 2022
Merged
6 tasks
xdkxlk added a commit to xdkxlk/rocketmq that referenced this issue Oct 26, 2022
@xdkxlk
[ISSUE apache#5402] not to decompress the body of messages when get r…
99ee18a 
…etry messages in PopReviveService
lizhanhui pushed a commit that referenced this issue Oct 27, 2022
@xdkxlk
[ISSUE #5402] not to decompress the body of messages when get retry m…
d54f8cb 
…essages in PopReviveService (#5403)
anuragmadnawat1 pushed a commit to anuragmadnawat1/rocketmq that referenced this issue Nov 2, 2022
@xdkxlk @anurag-harness
[ISSUE apache#5402] not to decompress the body of messages when get r…
a8bc002 
…etry messages in PopReviveService (apache#5403)
anuragmadnawat1 added a commit to anuragmadnawat1/rocketmq that referenced this issue Nov 2, 2022
@anuragmadnawat1 @xdkxlk
[ISSUE apache#5402] not to decompress the body of messages when get r…
3365cbd 
…etry messages in PopReviveService (apache#5403) (#37)

Co-authored-by: lk <xdkxlk@outlook.com>
drpmma pushed a commit that referenced this issue Feb 21, 2023
@xdkxlk @drpmma
[ISSUE #5402] not to decompress the body of messages when get retry m…
33ef875 
…essages in PopReviveService (#5403)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@xdkxlk