[ROCKETMQ-284] ExpressionMessageFilter will pass some message. #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vongosling pls have a review. |
vongosling
reviewed
Aug 29, 2017
| putMsg(master, topicCount, msgPerTopic); | ||
| // sleep to wait for consume queue has been constructed. | ||
| Thread.sleep(200); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
Could we using expected for exception test ?
| public void testGetMessage_withFilter_checkTagsCode() { | ||
| try { | ||
| putMsg(master, topicCount, msgPerTopic); | ||
| // sleep to wait for consume queue has been constructed. |
There was a problem hiding this comment.
Must we use latch to replace sleep ? Now ,we have polished our unit test within 3 minutes, thoughts ?@shroman
There was a problem hiding this comment.
sleep to replace sleep ?
vongosling
reviewed
Aug 29, 2017
| @@ -79,24 +79,17 @@ | |||
| try { | |||
| StoreHost = new InetSocketAddress(InetAddress.getLocalHost(), 8123); | |||
| } catch (UnknownHostException e) { | |||
| e.printStackTrace(); | |||
| } | |||
| try { | |||
| BornHost = new InetSocketAddress(InetAddress.getByName("127.0.0.1"), 0); | |||
| } catch (UnknownHostException e) { | |||
There was a problem hiding this comment.
no need to delete catch part ?
There was a problem hiding this comment.
Here, don't care about this exception, so not hide it .
| } catch (Exception e) { | ||
| e.printStackTrace(); | ||
| assertThat(true).isFalse(); | ||
| } |
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2017
Closes #160 from vsair/ROCKETMQ-284.
asfgit
pushed a commit
that referenced
this pull request
Aug 29, 2017
Author: vsair <liuxuedee@gmail.com> Closes #160 from vsair/ROCKETMQ-284.
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
lizhanhui
pushed a commit
to lizhanhui/rocketmq
that referenced
this pull request
Jun 25, 2019
Author: vsair <liuxuedee@gmail.com> Closes apache#160 from vsair/ROCKETMQ-284. Conflicts: broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
JiaMingLiu93
pushed a commit
to JiaMingLiu93/rocketmq
that referenced
this pull request
May 28, 2020
Author: vsair <liuxuedee@gmail.com> Closes apache#160 from vsair/ROCKETMQ-284.
lollipopjin
added a commit
to lollipopjin/rocketmq
that referenced
this pull request
Jun 16, 2022
…ature_1 * origin/develop_with_prehistory: (3800 commits) Issue apache#179 [BUG]check properties length Issue apache#161 printmsg bug 修复 Issue apache#175 change version to 3.6.3-SNAPSHOT Issue apache#175 pub 3.6.2 server release Issue apache#174 顺序消息重试次数超过默认值，导致消息直接进入死信队列 Issue apache#173 日志滚动异常，更新日志配置 Issue apache#172 rebalance 抛 Error 异常，导致 rebalance 被中断 Issue apache#171 指定消息 id 进行重新发送 Issue apache#146 add trace hook switch and consume return type Issue apache#146 add trace hook switch and consume return type Issue apache#169 Issue apache#158 1. Unify config manager to configuration in common. 2. Configuration is hold in controller. 3. Extend config object or property can register to configuration. Issue apache#163 1. command of get broker config Issue apache#163 1. Directly print msg after query by queue offset. Issue apache#163 1. format file header Issue apache#163 1. support for modifying the config of name server dynamically 2. add two request codes 3. add two commands 3. set config store path when start up using special property file Issue apache#137 【买卖家】队列热点数据分析 Issue apache#162 ConsumerConnection 获取连接失败。 Issue apache#161 printmsg 使用 tag 过滤时，拉消息不全 Issue apache#160 重置位点优化 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/ROCKETMQ-284
Solution:
Keep the tagscode transfer into MessageFilter is legal.