-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROCKETMQ-292]Delete system.exit in MQAdminStartup #169
Conversation
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module. Have you provide the test module ? |
System.exit() can be used to run shutdown hooks before the program quits. This is a convenient way to handle shutdown in bigger programs, where all parts of the program can't (and shouldn't) be aware of each other. For this reason, I am glad to see this improvement, thanks @lindzh |
I think there is no need to add any test case for this issue.Any opinion? IMO |
I think we just need to check if there're no such non-daemon threads, and commit this pr ;) |
LGTM |
1 similar comment
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
Author: lindzh <linsony0@163.com> Closes #169 from lindzh/fix_main_system.exit.
merged! |
show accumulation
Issue apache#169 1. show accumulation 2. support to show selected topic See merge request !24
Author: lindzh <linsony0@163.com> Closes apache#169 from lindzh/fix_main_system.exit.
…ature_1 * origin/develop_with_prehistory: (3800 commits) Issue apache#179 [BUG]check properties length Issue apache#161 printmsg bug 修复 Issue apache#175 change version to 3.6.3-SNAPSHOT Issue apache#175 pub 3.6.2 server release Issue apache#174 顺序消息重试次数超过默认值,导致消息直接进入死信队列 Issue apache#173 日志滚动异常,更新日志配置 Issue apache#172 rebalance 抛 Error 异常,导致 rebalance 被中断 Issue apache#171 指定消息 id 进行重新发送 Issue apache#146 add trace hook switch and consume return type Issue apache#146 add trace hook switch and consume return type Issue apache#169 Issue apache#158 1. Unify config manager to configuration in common. 2. Configuration is hold in controller. 3. Extend config object or property can register to configuration. Issue apache#163 1. command of get broker config Issue apache#163 1. Directly print msg after query by queue offset. Issue apache#163 1. format file header Issue apache#163 1. support for modifying the config of name server dynamically 2. add two request codes 3. add two commands 3. set config store path when start up using special property file Issue apache#137 【买卖家】队列热点数据分析 Issue apache#162 ConsumerConnection 获取连接失败。 Issue apache#161 printmsg 使用 tag 过滤时,拉消息不全 Issue apache#160 重置位点优化 ...
What is the purpose of the change
When using MQAdminStartup in a java process,some args problem may cause MQAdminStartup to call system.ext and this lead to main java process shutdown.
JIRA: https://issues.apache.org/jira/browse/ROCKETMQ-278.
Brief change log
Verifying this change
mqadmin testa
to verify.Follow this checklist to help us incorporate your contribution quickly and easily: