Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCKETMQ-361] Heartbeat handler use independently thread pool #225

Closed
wants to merge 8 commits into from
Closed

[ROCKETMQ-361] Heartbeat handler use independently thread pool #225

wants to merge 8 commits into from

Conversation

fuyou001
Copy link
Contributor

@fuyou001 fuyou001 commented Feb 9, 2018

What is the purpose of the change

thousands of client Sub message, when subscription change, broker notify all client with same cid,
causing related ThreadPoolExecutor pool full, so Heartbeat use independently thread pool

Brief changelog

increase notify consumerIds changed semaphore size

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ROCKETMQ-XXX] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@fuyou001 fuyou001 changed the base branch from master to develop February 9, 2018 10:00
@coveralls
Copy link

coveralls commented Feb 9, 2018

Coverage Status

Coverage increased (+0.004%) to 39.971% when pulling cbc5290 on fuyou001:ROCKETMQ-361 into a096580 on apache:develop.

@fuyou001 fuyou001 changed the title [ROCKETMQ-361] increase notify consumerIds changed semaphore size [ROCKETMQ-361] Heartbeat use independently thread pool Mar 7, 2018
@fuyou001 fuyou001 changed the title [ROCKETMQ-361] Heartbeat use independently thread pool [ROCKETMQ-361] Heartbeat handler use independently thread pool Mar 7, 2018
@fuyou001 fuyou001 closed this Mar 20, 2018
@fuyou001 fuyou001 deleted the ROCKETMQ-361 branch March 20, 2018 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants