-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RIP-19] Pop Consuming (submodule "broker") #2757
Conversation
Fix issue that when messages pop out but not ack so redeliver to retry topic, and next pop start from max offset so skip these messages incorrectly.
@@ -571,6 +571,11 @@ | |||
<artifactId>guava</artifactId> | |||
<version>19.0</version> | |||
</dependency> | |||
<dependency> | |||
<groupId>com.googlecode.concurrentlinkedhashmap</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not introduce this older(2015) dependency, you could check guava's MapMaker or CacheBuilder. Or, use Caffeine.
broker/src/main/java/org/apache/rocketmq/broker/loadbalance/AssignmentManager.java
Show resolved
Hide resolved
|
||
public NotifyMessageArrivingListener(final PullRequestHoldService pullRequestHoldService) { | ||
public NotifyMessageArrivingListener(final PullRequestHoldService pullRequestHoldService, final PopMessageProcessor popMessageProcessor) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is pop semantic? Common Queue Operations do not include pop except the special dequeue. Such a name can be confusing. IMO, We should use some common names in the industry. such as poll/pull, peek, push, and so on.
Make sure set the target branch to
develop
What is the purpose of the change
This is "broker" submodule of contribution for RIP-19
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.