Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-19] Pop Consuming (submodule "broker") #2757

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

ayanamist
Copy link
Contributor

Make sure set the target branch to develop

What is the purpose of the change

This is "broker" submodule of contribution for RIP-19

Brief changelog

  • Add QueryAssignment processor to control whether using pop mode or not.
  • Add core Pop/Ack/ChangeInvisible interface
  • Add pop consuming implementation using ScheduleService of store

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@ayanamist ayanamist changed the base branch from master to pop_consumer March 29, 2021 02:38
@coveralls
Copy link

coveralls commented Mar 29, 2021

Coverage Status

Coverage decreased (-0.3%) to 51.086% when pulling d54629c on ayanamist:dev_pop_consume into ea36854 on apache:pop_consumer.

Fix issue that when messages pop out but not ack so redeliver to retry topic, and next pop start from max offset so skip these messages incorrectly.
@@ -571,6 +571,11 @@
<artifactId>guava</artifactId>
<version>19.0</version>
</dependency>
<dependency>
<groupId>com.googlecode.concurrentlinkedhashmap</groupId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not introduce this older(2015) dependency, you could check guava's MapMaker or CacheBuilder. Or, use Caffeine.


public NotifyMessageArrivingListener(final PullRequestHoldService pullRequestHoldService) {
public NotifyMessageArrivingListener(final PullRequestHoldService pullRequestHoldService, final PopMessageProcessor popMessageProcessor) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is pop semantic? Common Queue Operations do not include pop except the special dequeue. Such a name can be confusing. IMO, We should use some common names in the industry. such as poll/pull, peek, push, and so on.

@vongosling vongosling added the progress/wip Work in progress. Accept or refused to be continue. label Mar 31, 2021
@dongeforever dongeforever self-requested a review April 7, 2021 12:50
@duhenglucky duhenglucky merged commit d3d0207 into apache:pop_consumer Apr 8, 2021
@ayanamist ayanamist deleted the dev_pop_consume branch June 16, 2021 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
progress/wip Work in progress. Accept or refused to be continue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants