Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3687] Fix wrong method comment about transaction message. #3689

Conversation

XiaoyiPeng
Copy link
Contributor

@XiaoyiPeng XiaoyiPeng commented Dec 31, 2021

Make sure set the target branch to develop

What is the purpose of the change

For issue #3687

Brief changelog

Fix wrong method comment about transaction message, this may mislead others unfamiliar with the code's logic.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 53.17% when pulling 92bf68c on XiaoyiPeng:wrong_method_comment_about_transaction_msg into 9f9b109 on apache:develop.

@codecov-commenter
Copy link

Codecov Report

Merging #3689 (92bf68c) into develop (9f9b109) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3689      +/-   ##
=============================================
- Coverage      47.37%   47.31%   -0.06%     
+ Complexity      5044     5032      -12     
=============================================
  Files            627      627              
  Lines          41348    41348              
  Branches        5372     5372              
=============================================
- Hits           19588    19565      -23     
- Misses         19332    19354      +22     
- Partials        2428     2429       +1     
Impacted Files Coverage Δ
.../transaction/queue/TransactionalMessageBridge.java 77.14% <100.00%> (ø)
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...org/apache/rocketmq/store/ha/WaitNotifyObject.java 66.07% <0.00%> (-5.36%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 41.79% <0.00%> (-2.99%) ⬇️
...ache/rocketmq/store/AllocateMappedFileService.java 39.02% <0.00%> (-2.44%) ⬇️
...a/org/apache/rocketmq/filter/util/BloomFilter.java 59.13% <0.00%> (-2.16%) ⬇️
...mq/client/impl/consumer/RebalanceLitePullImpl.java 48.52% <0.00%> (-1.48%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f9b109...92bf68c. Read the comment docs.

Copy link
Member

@francisoliverlee francisoliverlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francisoliverlee francisoliverlee merged commit a7b5903 into apache:develop Jan 6, 2022
@XiaoyiPeng XiaoyiPeng deleted the wrong_method_comment_about_transaction_msg branch January 6, 2022 12:48
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
…bout_transaction_msg

[ISSUE apache#3687] Fix wrong method comment about transaction message.
carlvine500 pushed a commit to carlvine500/rocketmq-apache that referenced this pull request Sep 10, 2024
…bout_transaction_msg

[ISSUE apache#3687] Fix wrong method comment about transaction message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants