Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs error #4023

Merged
merged 1 commit into from
Mar 24, 2022
Merged

fix docs error #4023

merged 1 commit into from
Mar 24, 2022

Conversation

Hen1ng
Copy link
Contributor

@Hen1ng Hen1ng commented Mar 23, 2022

Make sure set the target branch to develop

What is the purpose of the change

fix docs spell error

Brief changelog

fix docs spell error

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2022

Codecov Report

Merging #4023 (245df4d) into develop (03c5a3d) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##             develop    #4023      +/-   ##
=============================================
- Coverage      47.95%   47.87%   -0.09%     
+ Complexity      5004     4994      -10     
=============================================
  Files            633      633              
  Lines          42520    42528       +8     
  Branches        5571     5573       +2     
=============================================
- Hits           20391    20360      -31     
- Misses         19633    19671      +38     
- Partials        2496     2497       +1     
Impacted Files Coverage Δ
...rg/apache/rocketmq/common/stats/StatsSnapshot.java 84.61% <0.00%> (-15.39%) ⬇️
.../org/apache/rocketmq/store/PutMessageSpinLock.java 85.71% <0.00%> (-14.29%) ⬇️
.../apache/rocketmq/common/stats/MomentStatsItem.java 38.09% <0.00%> (-9.53%) ⬇️
...va/org/apache/rocketmq/store/FlushDiskWatcher.java 81.25% <0.00%> (-9.38%) ⬇️
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-8.70%) ⬇️
...va/org/apache/rocketmq/common/stats/StatsItem.java 50.00% <0.00%> (-5.00%) ⬇️
...org/apache/rocketmq/common/stats/StatsItemSet.java 43.28% <0.00%> (-2.99%) ⬇️
...ava/org/apache/rocketmq/filter/util/BitsArray.java 59.82% <0.00%> (-2.57%) ⬇️
.../rocketmq/broker/filter/ConsumerFilterManager.java 72.19% <0.00%> (-1.80%) ⬇️
...che/rocketmq/acl/plain/PlainPermissionManager.java 75.19% <0.00%> (-0.98%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03c5a3d...245df4d. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 51.907% when pulling 245df4d on Hen1ng:fix_doc_error into f57ea77 on apache:develop.

Copy link
Contributor

@Kvicii Kvicii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duhenglucky duhenglucky merged commit 1a72ffd into apache:develop Mar 24, 2022
GenerousMan pushed a commit to GenerousMan/rocketmq that referenced this pull request Aug 12, 2022
Co-authored-by: hening <ninghe.hn@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants