[ISSUE #3985] Remove shuffle operation before sorting the list of 'Fa…

…ultItem'. (#3986)
apache · Mar 14, 2022 · 03c5a3d · 03c5a3d
1 parent 2b51321
commit 03c5a3d
Showing 1 changed file with 0 additions and 5 deletions.
diff --git a/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java b/client/src/main/java/org/apache/rocketmq/client/latency/LatencyFaultToleranceImpl.java
@@ -70,12 +70,8 @@ public String pickOneAtLeast() {
             final FaultItem faultItem = elements.nextElement();
             tmpList.add(faultItem);
         }
-
         if (!tmpList.isEmpty()) {
-            Collections.shuffle(tmpList);
-
             Collections.sort(tmpList);
-
             final int half = tmpList.size() / 2;
             if (half <= 0) {
                 return tmpList.get(0).getName();
@@ -84,7 +80,6 @@ public String pickOneAtLeast() {
                 return tmpList.get(i).getName();
             }
         }
-
         return null;
     }