[RIP 30] Support Compaction topic #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta #4118 +/- ##
================================================
- Coverage 43.14% 43.02% -0.12%
- Complexity 6058 6153 +95
================================================
Files 801 810 +9
Lines 57086 57965 +879
Branches 7805 7923 +118
================================================
+ Hits 24630 24941 +311
- Misses 29230 29765 +535
- Partials 3226 3259 +33
Continue to review full report at Codecov.
|
ltamber
changed the title
RongtongJin
reviewed
Apr 10, 2022
store/src/main/java/org/apache/rocketmq/store/kv/CompactionService.java
Outdated
Show resolved
Hide resolved
store/src/main/java/org/apache/rocketmq/store/kv/CompactionPositionMgr.java
Show resolved
Hide resolved
humkum
reviewed
Apr 21, 2022
| CompactionLog log = new CompactionLog(defaultMessageStore, topic, queueId, | ||
| offsetMapSize, positionMgr, compactionLogPath, compactionCqPath); | ||
| compactionLogTable.put(topic + "_" + queueId, log); | ||
| compactionSchedule.scheduleWithFixedDelay(log::doCompaction, compactionInterval, compactionInterval, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Different compactionLog files are distinguished by topic and queueId, and do compaction in every compactionLog. Does this mean messages with the same keys must send to the same queue?
| MappedFile lastMappedFile = this.mappedFileQueue.getLastMappedFile(); | ||
| if (lastMappedFile == null) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Do I need to add synchronized or lock to ensure thread safety when restoring a ByteBuffer from native?
There was a problem hiding this comment.
the method recover invoked by only one thread, I think there is no need to add synchronized or lock
ltamber
force-pushed
the
5.0.0-beta-ctopic
branch
from
a072532
to
c130224
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refer to #3799
the implement was base on 5.0.0-beta