Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4384] Expand RocketMQ Topic/Group attributes #4386

Merged
merged 1 commit into from
May 27, 2022

Conversation

drpmma
Copy link
Contributor

@drpmma drpmma commented May 27, 2022

What is the purpose of the change

Topic and Group are important concepts in RocketMQ, but they are too simple to provide detailed information and more management ability. Therefore, there is a proposal to expand RocketMQ Topic/Group attributes.

Brief changelog

Add attributes below:

  • Topic Message Type
  • Consume Timeout for PushConsumer
  • Consume Retry Policy
  • Max Retry Times
  • Group Fifo Consume Flag

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #4386 (22b0625) into 5.0.0-beta (52e059e) will increase coverage by 0.02%.
The diff coverage is 38.70%.

@@               Coverage Diff                @@
##             5.0.0-beta    #4386      +/-   ##
================================================
+ Coverage         43.01%   43.04%   +0.02%     
- Complexity         6016     6040      +24     
================================================
  Files               796      801       +5     
  Lines             56943    57055     +112     
  Branches           7796     7800       +4     
================================================
+ Hits              24495    24558      +63     
- Misses            29240    29278      +38     
- Partials           3208     3219      +11     
Impacted Files Coverage Δ
...tmq/common/subscription/CustomizedRetryPolicy.java 0.00% <0.00%> (ø)
...mq/common/subscription/ExponentialRetryPolicy.java 0.00% <0.00%> (ø)
...ols/command/consumer/UpdateSubGroupSubCommand.java 0.00% <0.00%> (ø)
...n/java/org/apache/rocketmq/common/TopicConfig.java 56.39% <37.93%> (+6.82%) ⬆️
...rocketmq/common/subscription/GroupRetryPolicy.java 58.33% <58.33%> (ø)
...q/common/subscription/SubscriptionGroupConfig.java 61.90% <92.30%> (+6.34%) ⬆️
...va/org/apache/rocketmq/common/TopicAttributes.java 90.00% <100.00%> (+90.00%) ⬆️
...he/rocketmq/common/attribute/TopicMessageType.java 100.00% <100.00%> (ø)
...etmq/common/subscription/GroupRetryPolicyType.java 100.00% <100.00%> (ø)
...ache/rocketmq/common/stats/MomentStatsItemSet.java 39.13% <0.00%> (-4.35%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52e059e...22b0625. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 47.197% when pulling 22b0625 on drpmma:feature/resource into 52e059e on apache:5.0.0-beta.

@zhouxinyu zhouxinyu merged commit 3bddd51 into apache:5.0.0-beta May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants