-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Summer of code] Fix controller bugs #4399
[Summer of code] Fix controller bugs #4399
Conversation
LOGGER.info("Receive slave handshake, slaveId:{}, slaveAddress:{}, isSyncFromLastFile:{}, isAsyncLearner:{}", | ||
AutoSwitchHAConnection.this.slaveId, AutoSwitchHAConnection.this.slaveAddress, | ||
AutoSwitchHAConnection.this.isSyncFromLastFile, AutoSwitchHAConnection.this.isAsyncLearner); | ||
case HANDSHAKE: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要大括号
Good catch! A very insidious bug was found! |
This reverts commit 198bcdb.
Codecov Report
@@ Coverage Diff @@
## 5.0.0-beta-dledger-controller #4399 +/- ##
===================================================================
- Coverage 43.31% 43.27% -0.04%
+ Complexity 6337 6331 -6
===================================================================
Files 839 839
Lines 59625 59640 +15
Branches 8123 8130 +7
===================================================================
- Hits 25826 25812 -14
- Misses 30455 30478 +23
- Partials 3344 3350 +6
Continue to review full report at Codecov.
|
Make sure set the target branch to
develop
What is the purpose of the change
Tracking issue: #4330
Fix some bugs for controller mode.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR
.[ISSUE #123] Fix UnknownException when host config not exist
. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle
to make sure basic checks pass. Runmvn clean install -DskipITs
to make sure unit-test pass. Runmvn clean test-compile failsafe:integration-test
to make sure integration-test pass.