Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #5963] Remove the useless exception class: MQRedirectException #5964

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

socutes
Copy link
Contributor

@socutes socutes commented Feb 2, 2023

The exception class MQRedirectException defined in the client package is not used and can be removed.
path:org.apache.rocketmq.client.exception.MQRedirectException

Fix #5963

@socutes
Copy link
Contributor Author

socutes commented Feb 2, 2023

@zhouxinyu PTAL

@mxsm
Copy link
Member

mxsm commented Feb 2, 2023

Hey @socutes you can see this document how to link issue. You can link a pull request or branch to an issue to show that a fix is in progress and to automatically close the issue when the pull request or branch is merged.

@socutes
Copy link
Contributor Author

socutes commented Feb 2, 2023

link

Fixed, Thanks.
@mxsm PTAL

@socutes socutes changed the title [ISSUE #5963] Remove the useless exception class: MQRedirectException [ISSUE #5963] fixed: Remove the useless exception class: MQRedirectException Feb 2, 2023
@socutes socutes changed the title [ISSUE #5963] fixed: Remove the useless exception class: MQRedirectException [ISSUE #5963] Remove the useless exception class: MQRedirectException Feb 2, 2023
@zhouxinyu
Copy link
Member

LGTM, @aaron-ai Please help check if we have used this class in any runtime env or other repo.

@zhouxinyu zhouxinyu merged commit 4e67409 into apache:develop Feb 3, 2023
@aaron-ai
Copy link
Member

aaron-ai commented Feb 3, 2023

LGTM, @aaron-ai Please help check if we have used this class in any runtime env or other repo.

it is redundant seemingly.

@socutes socutes deleted the dev/removeUselessClass branch February 3, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the useless exception class: MQRedirectException
6 participants