Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #5994] [RIP-46] add pop and timer metrics #5995

Merged
merged 2 commits into from
Feb 8, 2023
Merged

[ISSUE #5994] [RIP-46] add pop and timer metrics #5995

merged 2 commits into from
Feb 8, 2023

Conversation

ShadowySpirits
Copy link
Member

close #5994

@ShadowySpirits ShadowySpirits marked this pull request as ready for review February 6, 2023 08:19
@codecov-commenter
Copy link

Codecov Report

Merging #5995 (1f88689) into develop (a1d1cf8) will decrease coverage by 0.11%.
The diff coverage is 27.50%.

@@              Coverage Diff              @@
##             develop    #5995      +/-   ##
=============================================
- Coverage      43.44%   43.34%   -0.11%     
- Complexity      8824     8837      +13     
=============================================
  Files           1090     1093       +3     
  Lines          76617    76832     +215     
  Branches       10006    10012       +6     
=============================================
+ Hits           33289    33302      +13     
- Misses         39166    39365     +199     
- Partials        4162     4165       +3
Impacted Files Coverage Δ
.../rocketmq/broker/metrics/BrokerMetricsManager.java 11.58% <0.00%> (-0.16%) ⬇️
...he/rocketmq/broker/metrics/PopMetricsConstant.java 0.00% <0.00%> (ø)
...tmq/store/metrics/DefaultStoreMetricsConstant.java 0.00% <ø> (ø)
...ieredstore/metrics/TieredStoreMetricsConstant.java 0.00% <ø> (ø)
...tieredstore/metrics/TieredStoreMetricsManager.java 57.86% <0.00%> (ø)
...cketmq/broker/processor/PopBufferMergeService.java 33.33% <16.66%> (-0.08%) ⬇️
...apache/rocketmq/store/timer/TimerMessageStore.java 54.15% <21.42%> (-0.14%) ⬇️
...etmq/store/metrics/DefaultStoreMetricsManager.java 18.18% <21.53%> (+18.18%) ⬆️
...he/rocketmq/broker/processor/PopReviveService.java 38.71% <27.77%> (-2.04%) ⬇️
...che/rocketmq/broker/metrics/PopMetricsManager.java 28.70% <28.70%> (ø)
... and 24 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xdkxlk
xdkxlk approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@xdkxlk xdkxlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lizhimins lizhimins changed the title [RIP-46] [ISSUE #5994] add pop and timer metrics [ISSUE #5994] [RIP-46] add pop and timer metrics Feb 8, 2023
@lizhimins lizhimins merged commit 9a55592 into apache:develop Feb 8, 2023
RongtongJin added a commit that referenced this pull request Feb 10, 2023
@TheR1sing3un @xdshent
@ShadowySpirits @loboxu @pingww @aaron-ai @Slideee @mxsm @hardyfish @RongtongJin @zhiliatom @drpmma @mahaitao617 @Oliverwqcwrw
[ISSUE #6023] Add a unit test to verify new register process in broke…
65ae97d 
…r with controller mode (#6024)

* refactor: simplify getPID (#5962)

* [ISSUE #5923] Add example tiered storage backend service provider (#5926)

* implement example file segment

* add metrics

* add readme

* fix license

* fix tests

* fix links in README.md

* add comment to PosixFileSegment and mark as experimental

* fix test

* optimize image quality

* Remove the useless exception class: MQRedirectException #5963

* [ISSUE #5965] Fix lmqTopicQueueTable initialization (#5968)

* [ISSUE #5965] Fix lmqTopicQueueTable initialization

* [ISSUE #5965] Fix lmqTopicQueueTable initialization

* [ISSUE #5890] Fix dledger logging (#5959)

* Fix dledger logging

* Add bridge into store module

* [ISSUE #5860] Set the value of order when create or update topic (#5861)

* [ISSUE #5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (#5940)

* [ISSUE #5924] Optimize UtilAll#sleep method (#5925)

* [ISSUE #5924]Optimize UtilAll#sleep method

* polish code

* [ISSUE #5986] optimize the BrokerOuterAPITest class code

Co-authored-by: zhouyunpeng <2474138779@qq.com>

* [ISSUE #5971] Make the internal logs related to the dledger in the controller print to a file separately (#5972)

* Make the internal logs related to the dledger in the controller print to a file separately

* Make the internal logs related to the dledger in the controller print to a file separately

* [ISSUE #5969] Remvoe duplicate deleteUnusedStats in admin processor (#5973)

* [ISSUE #5847] Add checkBlock for hasMsgFromQueue

* [ISSUE #5983] Make consumer support flow control code better (#5984)

* When encountering the flow control code, pull it after 20ms instead of 3s

* When encountering the flow control code, pull it after 20ms instead of 3s

* [ISSUE #5896] feat:add pop consumer example (#5991)

* feat:add pop consumer

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java

Co-authored-by: Oliver <wqdyxnbd@163.com>

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

---------

Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>

* [ISSUE #5942] Fix the produce count include the quantity of the system topic(#5943)

* [ISSUE #5999] Fix the TopicQueueMappingUtils comments typo (#6000)

* [ISSUE #5996] Optimize the RemotingSerializable class code (#5998)

* simplified RemotingSerializable null check

* optimize the RemotingSerializable class code

* [ISSUE #5994] [RIP-46] add pop and timer metrics (#5995)

* add pop and timer metrics
* fix according to review comment

* test(broker): add ReplicasManagerRegisterTest to test the register process

1. add ReplicasManagerRegisterTest to test the register process

* chore(pom): modify pom.xml to replace mockito with powermock

1. modify pom.xml to replace mockito with powermock

* build(bazel): export powermock in bazel

1. export powermock in bazel

---------

Co-authored-by: Xinda <xdshent@gmail.com>
Co-authored-by: SSpirits <admin@lv5.moe>
Co-authored-by: loboxu <loboxu@tencent.com>
Co-authored-by: pingww <pingw002@gmail.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Slideee <yechun@corp.netease.com>
Co-authored-by: mxsm <ljbmxsm@gmail.com>
Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com>
Co-authored-by: zhouyunpeng <2474138779@qq.com>
Co-authored-by: rongtong <jinrongtong5@163.com>
Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com>
Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com>
Co-authored-by: mahaitao <15828010639@163.com>
Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>
TheR1sing3un added a commit to TheR1sing3un/rocketmq that referenced this pull request Feb 16, 2023
@TheR1sing3un @xdshent
@ShadowySpirits @loboxu @pingww @aaron-ai @Slideee @mxsm @hardyfish @RongtongJin @zhiliatom @drpmma @mahaitao617 @Oliverwqcwrw
[ISSUE apache#6023] Add a unit test to verify new register process in…
81babd0 
… broker with controller mode (apache#6024)

* refactor: simplify getPID (apache#5962)

* [ISSUE apache#5923] Add example tiered storage backend service provider (apache#5926)

* implement example file segment

* add metrics

* add readme

* fix license

* fix tests

* fix links in README.md

* add comment to PosixFileSegment and mark as experimental

* fix test

* optimize image quality

* Remove the useless exception class: MQRedirectException apache#5963

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization (apache#5968)

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5890] Fix dledger logging (apache#5959)

* Fix dledger logging

* Add bridge into store module

* [ISSUE apache#5860] Set the value of order when create or update topic (apache#5861)

* [ISSUE apache#5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (apache#5940)

* [ISSUE apache#5924] Optimize UtilAll#sleep method (apache#5925)

* [ISSUE apache#5924]Optimize UtilAll#sleep method

* polish code

* [ISSUE apache#5986] optimize the BrokerOuterAPITest class code

Co-authored-by: zhouyunpeng <2474138779@qq.com>

* [ISSUE apache#5971] Make the internal logs related to the dledger in the controller print to a file separately (apache#5972)

* Make the internal logs related to the dledger in the controller print to a file separately

* Make the internal logs related to the dledger in the controller print to a file separately

* [ISSUE apache#5969] Remvoe duplicate deleteUnusedStats in admin processor (apache#5973)

* [ISSUE apache#5847] Add checkBlock for hasMsgFromQueue

* [ISSUE apache#5983] Make consumer support flow control code better (apache#5984)

* When encountering the flow control code, pull it after 20ms instead of 3s

* When encountering the flow control code, pull it after 20ms instead of 3s

* [ISSUE apache#5896] feat:add pop consumer example (apache#5991)

* feat:add pop consumer

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java

Co-authored-by: Oliver <wqdyxnbd@163.com>

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

---------

Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>

* [ISSUE apache#5942] Fix the produce count include the quantity of the system topic(apache#5943)

* [ISSUE apache#5999] Fix the TopicQueueMappingUtils comments typo (apache#6000)

* [ISSUE apache#5996] Optimize the RemotingSerializable class code (apache#5998)

* simplified RemotingSerializable null check

* optimize the RemotingSerializable class code

* [ISSUE apache#5994] [RIP-46] add pop and timer metrics (apache#5995)

* add pop and timer metrics
* fix according to review comment

* test(broker): add ReplicasManagerRegisterTest to test the register process

1. add ReplicasManagerRegisterTest to test the register process

* chore(pom): modify pom.xml to replace mockito with powermock

1. modify pom.xml to replace mockito with powermock

* build(bazel): export powermock in bazel

1. export powermock in bazel

---------

Co-authored-by: Xinda <xdshent@gmail.com>
Co-authored-by: SSpirits <admin@lv5.moe>
Co-authored-by: loboxu <loboxu@tencent.com>
Co-authored-by: pingww <pingw002@gmail.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Slideee <yechun@corp.netease.com>
Co-authored-by: mxsm <ljbmxsm@gmail.com>
Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com>
Co-authored-by: zhouyunpeng <2474138779@qq.com>
Co-authored-by: rongtong <jinrongtong5@163.com>
Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com>
Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com>
Co-authored-by: mahaitao <15828010639@163.com>
Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>
drpmma pushed a commit that referenced this pull request Feb 21, 2023
@ShadowySpirits @drpmma
[ISSUE #5994] [RIP-46] add pop and timer metrics (#5995)
8ac0476 
* add pop and timer metrics
* fix according to review comment
TheR1sing3un added a commit to TheR1sing3un/rocketmq that referenced this pull request Mar 13, 2023
@TheR1sing3un @xdshent
@ShadowySpirits @loboxu @pingww @aaron-ai @Slideee @mxsm @hardyfish @RongtongJin @zhiliatom @drpmma @mahaitao617 @Oliverwqcwrw
[ISSUE apache#6023] Add a unit test to verify new register process in…
4594574 
… broker with controller mode (apache#6024)

* refactor: simplify getPID (apache#5962)

* [ISSUE apache#5923] Add example tiered storage backend service provider (apache#5926)

* implement example file segment

* add metrics

* add readme

* fix license

* fix tests

* fix links in README.md

* add comment to PosixFileSegment and mark as experimental

* fix test

* optimize image quality

* Remove the useless exception class: MQRedirectException apache#5963

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization (apache#5968)

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5890] Fix dledger logging (apache#5959)

* Fix dledger logging

* Add bridge into store module

* [ISSUE apache#5860] Set the value of order when create or update topic (apache#5861)

* [ISSUE apache#5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (apache#5940)

* [ISSUE apache#5924] Optimize UtilAll#sleep method (apache#5925)

* [ISSUE apache#5924]Optimize UtilAll#sleep method

* polish code

* [ISSUE apache#5986] optimize the BrokerOuterAPITest class code

Co-authored-by: zhouyunpeng <2474138779@qq.com>

* [ISSUE apache#5971] Make the internal logs related to the dledger in the controller print to a file separately (apache#5972)

* Make the internal logs related to the dledger in the controller print to a file separately

* Make the internal logs related to the dledger in the controller print to a file separately

* [ISSUE apache#5969] Remvoe duplicate deleteUnusedStats in admin processor (apache#5973)

* [ISSUE apache#5847] Add checkBlock for hasMsgFromQueue

* [ISSUE apache#5983] Make consumer support flow control code better (apache#5984)

* When encountering the flow control code, pull it after 20ms instead of 3s

* When encountering the flow control code, pull it after 20ms instead of 3s

* [ISSUE apache#5896] feat:add pop consumer example (apache#5991)

* feat:add pop consumer

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java

Co-authored-by: Oliver <wqdyxnbd@163.com>

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

---------

Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>

* [ISSUE apache#5942] Fix the produce count include the quantity of the system topic(apache#5943)

* [ISSUE apache#5999] Fix the TopicQueueMappingUtils comments typo (apache#6000)

* [ISSUE apache#5996] Optimize the RemotingSerializable class code (apache#5998)

* simplified RemotingSerializable null check

* optimize the RemotingSerializable class code

* [ISSUE apache#5994] [RIP-46] add pop and timer metrics (apache#5995)

* add pop and timer metrics
* fix according to review comment

* test(broker): add ReplicasManagerRegisterTest to test the register process

1. add ReplicasManagerRegisterTest to test the register process

* chore(pom): modify pom.xml to replace mockito with powermock

1. modify pom.xml to replace mockito with powermock

* build(bazel): export powermock in bazel

1. export powermock in bazel

---------

Co-authored-by: Xinda <xdshent@gmail.com>
Co-authored-by: SSpirits <admin@lv5.moe>
Co-authored-by: loboxu <loboxu@tencent.com>
Co-authored-by: pingww <pingw002@gmail.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Slideee <yechun@corp.netease.com>
Co-authored-by: mxsm <ljbmxsm@gmail.com>
Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com>
Co-authored-by: zhouyunpeng <2474138779@qq.com>
Co-authored-by: rongtong <jinrongtong5@163.com>
Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com>
Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com>
Co-authored-by: mahaitao <15828010639@163.com>
Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>
RongtongJin added a commit that referenced this pull request Mar 14, 2023
@TheR1sing3un @xdshent
@ShadowySpirits @loboxu @pingww @aaron-ai @Slideee @mxsm @hardyfish @RongtongJin @zhiliatom @drpmma @mahaitao617 @Oliverwqcwrw
[ISSUE #6023] Add a unit test to verify new register process in broke…
3a69aae 
…r with controller mode (#6024)

* refactor: simplify getPID (#5962)

* [ISSUE #5923] Add example tiered storage backend service provider (#5926)

* implement example file segment

* add metrics

* add readme

* fix license

* fix tests

* fix links in README.md

* add comment to PosixFileSegment and mark as experimental

* fix test

* optimize image quality

* Remove the useless exception class: MQRedirectException #5963

* [ISSUE #5965] Fix lmqTopicQueueTable initialization (#5968)

* [ISSUE #5965] Fix lmqTopicQueueTable initialization

* [ISSUE #5965] Fix lmqTopicQueueTable initialization

* [ISSUE #5890] Fix dledger logging (#5959)

* Fix dledger logging

* Add bridge into store module

* [ISSUE #5860] Set the value of order when create or update topic (#5861)

* [ISSUE #5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (#5940)

* [ISSUE #5924] Optimize UtilAll#sleep method (#5925)

* [ISSUE #5924]Optimize UtilAll#sleep method

* polish code

* [ISSUE #5986] optimize the BrokerOuterAPITest class code

Co-authored-by: zhouyunpeng <2474138779@qq.com>

* [ISSUE #5971] Make the internal logs related to the dledger in the controller print to a file separately (#5972)

* Make the internal logs related to the dledger in the controller print to a file separately

* Make the internal logs related to the dledger in the controller print to a file separately

* [ISSUE #5969] Remvoe duplicate deleteUnusedStats in admin processor (#5973)

* [ISSUE #5847] Add checkBlock for hasMsgFromQueue

* [ISSUE #5983] Make consumer support flow control code better (#5984)

* When encountering the flow control code, pull it after 20ms instead of 3s

* When encountering the flow control code, pull it after 20ms instead of 3s

* [ISSUE #5896] feat:add pop consumer example (#5991)

* feat:add pop consumer

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java

Co-authored-by: Oliver <wqdyxnbd@163.com>

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

---------

Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>

* [ISSUE #5942] Fix the produce count include the quantity of the system topic(#5943)

* [ISSUE #5999] Fix the TopicQueueMappingUtils comments typo (#6000)

* [ISSUE #5996] Optimize the RemotingSerializable class code (#5998)

* simplified RemotingSerializable null check

* optimize the RemotingSerializable class code

* [ISSUE #5994] [RIP-46] add pop and timer metrics (#5995)

* add pop and timer metrics
* fix according to review comment

* test(broker): add ReplicasManagerRegisterTest to test the register process

1. add ReplicasManagerRegisterTest to test the register process

* chore(pom): modify pom.xml to replace mockito with powermock

1. modify pom.xml to replace mockito with powermock

* build(bazel): export powermock in bazel

1. export powermock in bazel

---------

Co-authored-by: Xinda <xdshent@gmail.com>
Co-authored-by: SSpirits <admin@lv5.moe>
Co-authored-by: loboxu <loboxu@tencent.com>
Co-authored-by: pingww <pingw002@gmail.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Slideee <yechun@corp.netease.com>
Co-authored-by: mxsm <ljbmxsm@gmail.com>
Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com>
Co-authored-by: zhouyunpeng <2474138779@qq.com>
Co-authored-by: rongtong <jinrongtong5@163.com>
Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com>
Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com>
Co-authored-by: mahaitao <15828010639@163.com>
Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>
miles-ton pushed a commit to miles-ton/rocketmq that referenced this pull request Mar 16, 2023
@TheR1sing3un @xdshent
@ShadowySpirits @loboxu @pingww @aaron-ai @Slideee @mxsm @hardyfish @RongtongJin @zhiliatom @drpmma @mahaitao617 @Oliverwqcwrw @miles-ton
[ISSUE apache#6023] Add a unit test to verify new register process in…
6bf5b75 
… broker with controller mode (apache#6024)

* refactor: simplify getPID (apache#5962)

* [ISSUE apache#5923] Add example tiered storage backend service provider (apache#5926)

* implement example file segment

* add metrics

* add readme

* fix license

* fix tests

* fix links in README.md

* add comment to PosixFileSegment and mark as experimental

* fix test

* optimize image quality

* Remove the useless exception class: MQRedirectException apache#5963

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization (apache#5968)

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5890] Fix dledger logging (apache#5959)

* Fix dledger logging

* Add bridge into store module

* [ISSUE apache#5860] Set the value of order when create or update topic (apache#5861)

* [ISSUE apache#5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (apache#5940)

* [ISSUE apache#5924] Optimize UtilAll#sleep method (apache#5925)

* [ISSUE apache#5924]Optimize UtilAll#sleep method

* polish code

* [ISSUE apache#5986] optimize the BrokerOuterAPITest class code

Co-authored-by: zhouyunpeng <2474138779@qq.com>

* [ISSUE apache#5971] Make the internal logs related to the dledger in the controller print to a file separately (apache#5972)

* Make the internal logs related to the dledger in the controller print to a file separately

* Make the internal logs related to the dledger in the controller print to a file separately

* [ISSUE apache#5969] Remvoe duplicate deleteUnusedStats in admin processor (apache#5973)

* [ISSUE apache#5847] Add checkBlock for hasMsgFromQueue

* [ISSUE apache#5983] Make consumer support flow control code better (apache#5984)

* When encountering the flow control code, pull it after 20ms instead of 3s

* When encountering the flow control code, pull it after 20ms instead of 3s

* [ISSUE apache#5896] feat:add pop consumer example (apache#5991)

* feat:add pop consumer

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java

Co-authored-by: Oliver <wqdyxnbd@163.com>

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

---------

Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>

* [ISSUE apache#5942] Fix the produce count include the quantity of the system topic(apache#5943)

* [ISSUE apache#5999] Fix the TopicQueueMappingUtils comments typo (apache#6000)

* [ISSUE apache#5996] Optimize the RemotingSerializable class code (apache#5998)

* simplified RemotingSerializable null check

* optimize the RemotingSerializable class code

* [ISSUE apache#5994] [RIP-46] add pop and timer metrics (apache#5995)

* add pop and timer metrics
* fix according to review comment

* test(broker): add ReplicasManagerRegisterTest to test the register process

1. add ReplicasManagerRegisterTest to test the register process

* chore(pom): modify pom.xml to replace mockito with powermock

1. modify pom.xml to replace mockito with powermock

* build(bazel): export powermock in bazel

1. export powermock in bazel

---------

Co-authored-by: Xinda <xdshent@gmail.com>
Co-authored-by: SSpirits <admin@lv5.moe>
Co-authored-by: loboxu <loboxu@tencent.com>
Co-authored-by: pingww <pingw002@gmail.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Slideee <yechun@corp.netease.com>
Co-authored-by: mxsm <ljbmxsm@gmail.com>
Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com>
Co-authored-by: zhouyunpeng <2474138779@qq.com>
Co-authored-by: rongtong <jinrongtong5@163.com>
Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com>
Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com>
Co-authored-by: mahaitao <15828010639@163.com>
Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>
fuyou001 pushed a commit to fuyou001/rocketmq that referenced this pull request Mar 16, 2023
@TheR1sing3un @xdshent
@ShadowySpirits @loboxu @pingww @aaron-ai @Slideee @mxsm @hardyfish @RongtongJin @zhiliatom @drpmma @mahaitao617 @Oliverwqcwrw @fuyou001
[ISSUE apache#6023] Add a unit test to verify new register process in…
d29826b 
… broker with controller mode (apache#6024)

* refactor: simplify getPID (apache#5962)

* [ISSUE apache#5923] Add example tiered storage backend service provider (apache#5926)

* implement example file segment

* add metrics

* add readme

* fix license

* fix tests

* fix links in README.md

* add comment to PosixFileSegment and mark as experimental

* fix test

* optimize image quality

* Remove the useless exception class: MQRedirectException apache#5963

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization (apache#5968)

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* [ISSUE apache#5890] Fix dledger logging (apache#5959)

* Fix dledger logging

* Add bridge into store module

* [ISSUE apache#5860] Set the value of order when create or update topic (apache#5861)

* [ISSUE apache#5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (apache#5940)

* [ISSUE apache#5924] Optimize UtilAll#sleep method (apache#5925)

* [ISSUE apache#5924]Optimize UtilAll#sleep method

* polish code

* [ISSUE apache#5986] optimize the BrokerOuterAPITest class code

Co-authored-by: zhouyunpeng <2474138779@qq.com>

* [ISSUE apache#5971] Make the internal logs related to the dledger in the controller print to a file separately (apache#5972)

* Make the internal logs related to the dledger in the controller print to a file separately

* Make the internal logs related to the dledger in the controller print to a file separately

* [ISSUE apache#5969] Remvoe duplicate deleteUnusedStats in admin processor (apache#5973)

* [ISSUE apache#5847] Add checkBlock for hasMsgFromQueue

* [ISSUE apache#5983] Make consumer support flow control code better (apache#5984)

* When encountering the flow control code, pull it after 20ms instead of 3s

* When encountering the flow control code, pull it after 20ms instead of 3s

* [ISSUE apache#5896] feat:add pop consumer example (apache#5991)

* feat:add pop consumer

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java

Co-authored-by: Oliver <wqdyxnbd@163.com>

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

* feat:fix

---------

Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>

* [ISSUE apache#5942] Fix the produce count include the quantity of the system topic(apache#5943)

* [ISSUE apache#5999] Fix the TopicQueueMappingUtils comments typo (apache#6000)

* [ISSUE apache#5996] Optimize the RemotingSerializable class code (apache#5998)

* simplified RemotingSerializable null check

* optimize the RemotingSerializable class code

* [ISSUE apache#5994] [RIP-46] add pop and timer metrics (apache#5995)

* add pop and timer metrics
* fix according to review comment

* test(broker): add ReplicasManagerRegisterTest to test the register process

1. add ReplicasManagerRegisterTest to test the register process

* chore(pom): modify pom.xml to replace mockito with powermock

1. modify pom.xml to replace mockito with powermock

* build(bazel): export powermock in bazel

1. export powermock in bazel

---------

Co-authored-by: Xinda <xdshent@gmail.com>
Co-authored-by: SSpirits <admin@lv5.moe>
Co-authored-by: loboxu <loboxu@tencent.com>
Co-authored-by: pingww <pingw002@gmail.com>
Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com>
Co-authored-by: Slideee <yechun@corp.netease.com>
Co-authored-by: mxsm <ljbmxsm@gmail.com>
Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com>
Co-authored-by: zhouyunpeng <2474138779@qq.com>
Co-authored-by: rongtong <jinrongtong5@163.com>
Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com>
Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com>
Co-authored-by: mahaitao <15828010639@163.com>
Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local>
Co-authored-by: Oliver <wqdyxnbd@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizhimins lizhimins lizhimins left review comments

@xdkxlk xdkxlk xdkxlk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RIP-46] Add pop and timer metrics
4 participants
@ShadowySpirits @codecov-commenter @xdkxlk @lizhimins