Add a unit test to verify new register process in broker with controller mode #6024

TheR1sing3un · 2023-02-09T15:42:57Z

Make sure set the target branch to develop

What is the purpose of the change

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

…er (apache#5926) * implement example file segment * add metrics * add readme * fix license * fix tests * fix links in README.md * add comment to PosixFileSegment and mark as experimental * fix test * optimize image quality

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

* Fix dledger logging * Add bridge into store module

apache#5861)

…er catch code block log print level from info to warn (apache#5940)

* [ISSUE apache#5924]Optimize UtilAll#sleep method * polish code

Co-authored-by: zhouyunpeng <2474138779@qq.com>

…the controller print to a file separately (apache#5972) * Make the internal logs related to the dledger in the controller print to a file separately * Make the internal logs related to the dledger in the controller print to a file separately

…ssor (apache#5973)

…pache#5984) * When encountering the flow control code, pull it after 20ms instead of 3s * When encountering the flow control code, pull it after 20ms instead of 3s

* feat:add pop consumer * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java Co-authored-by: Oliver <wqdyxnbd@163.com> * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix --------- Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local> Co-authored-by: Oliver <wqdyxnbd@163.com>

… system topic(apache#5943)

…che#6000)

…che#5998) * simplified RemotingSerializable null check * optimize the RemotingSerializable class code

* add pop and timer metrics * fix according to review comment

# Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java

…ocess 1. add ReplicasManagerRegisterTest to test the register process

1. modify pom.xml to replace mockito with powermock

codecov-commenter · 2023-02-10T02:09:08Z

Codecov Report

❗ No coverage uploaded for pull request base (dledger-controller-brokerId@493a817). Click here to learn what that means.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##             dledger-controller-brokerId    #6024   +/-   ##
==============================================================
  Coverage                               ?   43.24%           
  Complexity                             ?     8874           
==============================================================
  Files                                  ?     1104           
  Lines                                  ?    77299           
  Branches                               ?    10037           
==============================================================
  Hits                                   ?    33428           
  Misses                                 ?    39691           
  Partials                               ?     4180

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

1. export powermock in bazel

… broker with controller mode (apache#6024) * refactor: simplify getPID (apache#5962) * [ISSUE apache#5923] Add example tiered storage backend service provider (apache#5926) * implement example file segment * add metrics * add readme * fix license * fix tests * fix links in README.md * add comment to PosixFileSegment and mark as experimental * fix test * optimize image quality * Remove the useless exception class: MQRedirectException apache#5963 * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization (apache#5968) * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization * [ISSUE apache#5890] Fix dledger logging (apache#5959) * Fix dledger logging * Add bridge into store module * [ISSUE apache#5860] Set the value of order when create or update topic (apache#5861) * [ISSUE apache#5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (apache#5940) * [ISSUE apache#5924] Optimize UtilAll#sleep method (apache#5925) * [ISSUE apache#5924]Optimize UtilAll#sleep method * polish code * [ISSUE apache#5986] optimize the BrokerOuterAPITest class code Co-authored-by: zhouyunpeng <2474138779@qq.com> * [ISSUE apache#5971] Make the internal logs related to the dledger in the controller print to a file separately (apache#5972) * Make the internal logs related to the dledger in the controller print to a file separately * Make the internal logs related to the dledger in the controller print to a file separately * [ISSUE apache#5969] Remvoe duplicate deleteUnusedStats in admin processor (apache#5973) * [ISSUE apache#5847] Add checkBlock for hasMsgFromQueue * [ISSUE apache#5983] Make consumer support flow control code better (apache#5984) * When encountering the flow control code, pull it after 20ms instead of 3s * When encountering the flow control code, pull it after 20ms instead of 3s * [ISSUE apache#5896] feat:add pop consumer example (apache#5991) * feat:add pop consumer * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java Co-authored-by: Oliver <wqdyxnbd@163.com> * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix --------- Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local> Co-authored-by: Oliver <wqdyxnbd@163.com> * [ISSUE apache#5942] Fix the produce count include the quantity of the system topic(apache#5943) * [ISSUE apache#5999] Fix the TopicQueueMappingUtils comments typo (apache#6000) * [ISSUE apache#5996] Optimize the RemotingSerializable class code (apache#5998) * simplified RemotingSerializable null check * optimize the RemotingSerializable class code * [ISSUE apache#5994] [RIP-46] add pop and timer metrics (apache#5995) * add pop and timer metrics * fix according to review comment * test(broker): add ReplicasManagerRegisterTest to test the register process 1. add ReplicasManagerRegisterTest to test the register process * chore(pom): modify pom.xml to replace mockito with powermock 1. modify pom.xml to replace mockito with powermock * build(bazel): export powermock in bazel 1. export powermock in bazel --------- Co-authored-by: Xinda <xdshent@gmail.com> Co-authored-by: SSpirits <admin@lv5.moe> Co-authored-by: loboxu <loboxu@tencent.com> Co-authored-by: pingww <pingw002@gmail.com> Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com> Co-authored-by: Slideee <yechun@corp.netease.com> Co-authored-by: mxsm <ljbmxsm@gmail.com> Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com> Co-authored-by: zhouyunpeng <2474138779@qq.com> Co-authored-by: rongtong <jinrongtong5@163.com> Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com> Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com> Co-authored-by: mahaitao <15828010639@163.com> Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local> Co-authored-by: Oliver <wqdyxnbd@163.com>

…r with controller mode (#6024) * refactor: simplify getPID (#5962) * [ISSUE #5923] Add example tiered storage backend service provider (#5926) * implement example file segment * add metrics * add readme * fix license * fix tests * fix links in README.md * add comment to PosixFileSegment and mark as experimental * fix test * optimize image quality * Remove the useless exception class: MQRedirectException #5963 * [ISSUE #5965] Fix lmqTopicQueueTable initialization (#5968) * [ISSUE #5965] Fix lmqTopicQueueTable initialization * [ISSUE #5965] Fix lmqTopicQueueTable initialization * [ISSUE #5890] Fix dledger logging (#5959) * Fix dledger logging * Add bridge into store module * [ISSUE #5860] Set the value of order when create or update topic (#5861) * [ISSUE #5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (#5940) * [ISSUE #5924] Optimize UtilAll#sleep method (#5925) * [ISSUE #5924]Optimize UtilAll#sleep method * polish code * [ISSUE #5986] optimize the BrokerOuterAPITest class code Co-authored-by: zhouyunpeng <2474138779@qq.com> * [ISSUE #5971] Make the internal logs related to the dledger in the controller print to a file separately (#5972) * Make the internal logs related to the dledger in the controller print to a file separately * Make the internal logs related to the dledger in the controller print to a file separately * [ISSUE #5969] Remvoe duplicate deleteUnusedStats in admin processor (#5973) * [ISSUE #5847] Add checkBlock for hasMsgFromQueue * [ISSUE #5983] Make consumer support flow control code better (#5984) * When encountering the flow control code, pull it after 20ms instead of 3s * When encountering the flow control code, pull it after 20ms instead of 3s * [ISSUE #5896] feat:add pop consumer example (#5991) * feat:add pop consumer * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java Co-authored-by: Oliver <wqdyxnbd@163.com> * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix --------- Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local> Co-authored-by: Oliver <wqdyxnbd@163.com> * [ISSUE #5942] Fix the produce count include the quantity of the system topic(#5943) * [ISSUE #5999] Fix the TopicQueueMappingUtils comments typo (#6000) * [ISSUE #5996] Optimize the RemotingSerializable class code (#5998) * simplified RemotingSerializable null check * optimize the RemotingSerializable class code * [ISSUE #5994] [RIP-46] add pop and timer metrics (#5995) * add pop and timer metrics * fix according to review comment * test(broker): add ReplicasManagerRegisterTest to test the register process 1. add ReplicasManagerRegisterTest to test the register process * chore(pom): modify pom.xml to replace mockito with powermock 1. modify pom.xml to replace mockito with powermock * build(bazel): export powermock in bazel 1. export powermock in bazel --------- Co-authored-by: Xinda <xdshent@gmail.com> Co-authored-by: SSpirits <admin@lv5.moe> Co-authored-by: loboxu <loboxu@tencent.com> Co-authored-by: pingww <pingw002@gmail.com> Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com> Co-authored-by: Slideee <yechun@corp.netease.com> Co-authored-by: mxsm <ljbmxsm@gmail.com> Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com> Co-authored-by: zhouyunpeng <2474138779@qq.com> Co-authored-by: rongtong <jinrongtong5@163.com> Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com> Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com> Co-authored-by: mahaitao <15828010639@163.com> Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local> Co-authored-by: Oliver <wqdyxnbd@163.com>

… broker with controller mode (apache#6024) * refactor: simplify getPID (apache#5962) * [ISSUE apache#5923] Add example tiered storage backend service provider (apache#5926) * implement example file segment * add metrics * add readme * fix license * fix tests * fix links in README.md * add comment to PosixFileSegment and mark as experimental * fix test * optimize image quality * Remove the useless exception class: MQRedirectException apache#5963 * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization (apache#5968) * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization * [ISSUE apache#5890] Fix dledger logging (apache#5959) * Fix dledger logging * Add bridge into store module * [ISSUE apache#5860] Set the value of order when create or update topic (apache#5861) * [ISSUE apache#5939]Adjust the MQClientInstance#sendHeartbeatToAllBroker catch code block log print level from info to warn (apache#5940) * [ISSUE apache#5924] Optimize UtilAll#sleep method (apache#5925) * [ISSUE apache#5924]Optimize UtilAll#sleep method * polish code * [ISSUE apache#5986] optimize the BrokerOuterAPITest class code Co-authored-by: zhouyunpeng <2474138779@qq.com> * [ISSUE apache#5971] Make the internal logs related to the dledger in the controller print to a file separately (apache#5972) * Make the internal logs related to the dledger in the controller print to a file separately * Make the internal logs related to the dledger in the controller print to a file separately * [ISSUE apache#5969] Remvoe duplicate deleteUnusedStats in admin processor (apache#5973) * [ISSUE apache#5847] Add checkBlock for hasMsgFromQueue * [ISSUE apache#5983] Make consumer support flow control code better (apache#5984) * When encountering the flow control code, pull it after 20ms instead of 3s * When encountering the flow control code, pull it after 20ms instead of 3s * [ISSUE apache#5896] feat:add pop consumer example (apache#5991) * feat:add pop consumer * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * Update example/src/main/java/org/apache/rocketmq/example/simple/PushConsumer.java Co-authored-by: Oliver <wqdyxnbd@163.com> * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix * feat:fix --------- Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local> Co-authored-by: Oliver <wqdyxnbd@163.com> * [ISSUE apache#5942] Fix the produce count include the quantity of the system topic(apache#5943) * [ISSUE apache#5999] Fix the TopicQueueMappingUtils comments typo (apache#6000) * [ISSUE apache#5996] Optimize the RemotingSerializable class code (apache#5998) * simplified RemotingSerializable null check * optimize the RemotingSerializable class code * [ISSUE apache#5994] [RIP-46] add pop and timer metrics (apache#5995) * add pop and timer metrics * fix according to review comment * test(broker): add ReplicasManagerRegisterTest to test the register process 1. add ReplicasManagerRegisterTest to test the register process * chore(pom): modify pom.xml to replace mockito with powermock 1. modify pom.xml to replace mockito with powermock * build(bazel): export powermock in bazel 1. export powermock in bazel --------- Co-authored-by: Xinda <xdshent@gmail.com> Co-authored-by: SSpirits <admin@lv5.moe> Co-authored-by: loboxu <loboxu@tencent.com> Co-authored-by: pingww <pingw002@gmail.com> Co-authored-by: Aaron Ai <yangkun.ayk@gmail.com> Co-authored-by: Slideee <yechun@corp.netease.com> Co-authored-by: mxsm <ljbmxsm@gmail.com> Co-authored-by: hardyfish <85128645+hardyfish@users.noreply.github.com> Co-authored-by: zhouyunpeng <2474138779@qq.com> Co-authored-by: rongtong <jinrongtong5@163.com> Co-authored-by: zhiliatom <87265072+zhiliatom@users.noreply.github.com> Co-authored-by: zhouxiang <zhouxiang.zzx@alibaba-inc.com> Co-authored-by: mahaitao <15828010639@163.com> Co-authored-by: mahaitao617 <mahaitao617@mahaitao617deMacBook-Pro.local> Co-authored-by: Oliver <wqdyxnbd@163.com>

xdshent and others added 21 commits February 2, 2023 11:15

refactor: simplify getPID (apache#5962)

0c26369

Remove the useless exception class: MQRedirectException apache#5963

4e67409

[ISSUE apache#5965] Fix lmqTopicQueueTable initialization (apache#5968)

4628021

* [ISSUE apache#5965] Fix lmqTopicQueueTable initialization * [ISSUE apache#5965] Fix lmqTopicQueueTable initialization

[ISSUE apache#5890] Fix dledger logging (apache#5959)

ff8c4c8

* Fix dledger logging * Add bridge into store module

[ISSUE apache#5860] Set the value of order when create or update topic (

6268605

apache#5861)

[ISSUE apache#5939]Adjust the MQClientInstance#sendHeartbeatToAllBrok…

ce2ecc3

…er catch code block log print level from info to warn (apache#5940)

[ISSUE apache#5924] Optimize UtilAll#sleep method (apache#5925)

2545b78

* [ISSUE apache#5924]Optimize UtilAll#sleep method * polish code

[ISSUE apache#5986] optimize the BrokerOuterAPITest class code

da531ef

Co-authored-by: zhouyunpeng <2474138779@qq.com>

[ISSUE apache#5969] Remvoe duplicate deleteUnusedStats in admin proce…

b6e0bf3

…ssor (apache#5973)

[ISSUE apache#5847] Add checkBlock for hasMsgFromQueue

671977e

[ISSUE apache#5983] Make consumer support flow control code better (a…

a1d1cf8

…pache#5984) * When encountering the flow control code, pull it after 20ms instead of 3s * When encountering the flow control code, pull it after 20ms instead of 3s

[ISSUE apache#5942] Fix the produce count include the quantity of the…

59f056d

… system topic(apache#5943)

[ISSUE apache#5999] Fix the TopicQueueMappingUtils comments typo (apa…

4ca7e79

…che#6000)

[ISSUE apache#5996] Optimize the RemotingSerializable class code (apa…

e47e3cd

…che#5998) * simplified RemotingSerializable null check * optimize the RemotingSerializable class code

[ISSUE apache#5994] [RIP-46] add pop and timer metrics (apache#5995)

9a55592

* add pop and timer metrics * fix according to review comment

Merge branch 'develop' into improve_registration_process_test

b622a10

# Conflicts: # client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java

test(broker): add ReplicasManagerRegisterTest to test the register pr…

72a6289

…ocess 1. add ReplicasManagerRegisterTest to test the register process

chore(pom): modify pom.xml to replace mockito with powermock

3acc97e

1. modify pom.xml to replace mockito with powermock

build(bazel): export powermock in bazel

13359d6

1. export powermock in bazel

TheR1sing3un force-pushed the improve_registration_process_test branch from 08bfb2f to 13359d6 Compare February 10, 2023 03:12

RongtongJin approved these changes Feb 10, 2023

View reviewed changes

RongtongJin merged commit 65ae97d into apache:dledger-controller-brokerId Feb 10, 2023

RongtongJin added the module/ha high availably related label Feb 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a unit test to verify new register process in broker with controller mode #6024

Add a unit test to verify new register process in broker with controller mode #6024

TheR1sing3un commented Feb 9, 2023

codecov-commenter commented Feb 10, 2023 •

edited

Loading

Add a unit test to verify new register process in broker with controller mode #6024

Add a unit test to verify new register process in broker with controller mode #6024

Conversation

TheR1sing3un commented Feb 9, 2023

What is the purpose of the change

Brief changelog

Verifying this change

codecov-commenter commented Feb 10, 2023 • edited Loading

Codecov Report

codecov-commenter commented Feb 10, 2023 •

edited

Loading