[ISSUE #7013]polish ColdDataCheckService's logic #7014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RongtongJin
reviewed
Jul 11, 2023
Comment on lines
2096
to
2099
| } catch (Exception e) { | ||
| log.error("Before scanning files in pagecache, initing has failed.", e); | ||
| return; | ||
| } |
There was a problem hiding this comment.
这里无法抓住java.lang.UnsatisfiedLinkError
RongtongJin
approved these changes
Jul 11, 2023
lizhimins
pushed a commit
to lizhimins/rocketmq
that referenced
this pull request
Jul 26, 2023
* polish coldCtrl * remove the catch.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #7013
Brief Description
How Did You Test This Change?