Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #7013]polish ColdDataCheckService's logic #7014

Merged
merged 2 commits into from
Jul 11, 2023
Merged

[ISSUE #7013]polish ColdDataCheckService's logic #7014

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c02a73c
polish coldCtrl
GenerousMan Jul 11, 2023
4526eea
remove the catch.
GenerousMan Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion store/src/main/java/org/apache/rocketmq/store/CommitLog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2089,6 +2089,16 @@ public void run() {
} else {
this.waitForRunning(defaultMessageStore.getMessageStoreConfig().getTimerColdDataCheckIntervalMs());
}

if (pageSize < 0) {
try {
initPageSize();
} catch (Exception e) {
log.error("Before scanning files in pagecache, initing has failed.", e);
return;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里无法抓住java.lang.UnsatisfiedLinkError

}

long beginClockTimestamp = this.systemClock.now();
scanFilesInPageCache();
long costTime = this.systemClock.now() - beginClockTimestamp;
Expand Down Expand Up @@ -2182,7 +2192,7 @@ private byte[] checkFileInPageCache(MappedFile mappedFile) {
}

private void initPageSize() {
if (pageSize < 0) {
if (pageSize < 0 && defaultMessageStore.getMessageStoreConfig().isColdDataFlowControlEnable()) {
try {
if (!MixAll.isWindows()) {
pageSize = LibC.INSTANCE.getpagesize();
Expand Down
Loading