Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RIP-9] Added sample English documents of English transaction messages #781

Merged
merged 1 commit into from
Feb 19, 2019

Conversation

chenhaoxiang
Copy link
Contributor

What is the purpose of the change

RocketMQ Developer Guide doc

Brief changelog

Organize the English translation of the RocketMQ transaction message sample into the doc/en directory

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 44.798% when pulling 5b47023 on chenhaoxiang:develop into 6a573a7 on apache:develop.

@ShannonDing ShannonDing added this to the 4.4.1 milestone Feb 18, 2019
Copy link
Contributor

@wlliqipeng wlliqipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duhenglucky duhenglucky merged commit e01b5ae into apache:develop Feb 19, 2019
@wlliqipeng wlliqipeng modified the milestones: 4.4.1, 4.5.0 Mar 8, 2019
JiaMingLiu93 pushed a commit to JiaMingLiu93/rocketmq that referenced this pull request May 28, 2020
[RIP-9] Added sample English documents of English transaction messages
pulllock pushed a commit to pulllock/rocketmq that referenced this pull request Oct 19, 2023
[RIP-9] Added sample English documents of English transaction messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants