Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8348] Allow custom fast-failure queues to be added in BrokerFastFailure #8347

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

RongtongJin
Copy link
Contributor

@RongtongJin RongtongJin commented Jul 1, 2024

Which Issue(s) This PR Fixes

Fixes #8348

Brief Description

Allow custom fast-failure queues to be added in BrokerFastFailure

How Did You Test This Change?

@RongtongJin RongtongJin changed the title Allow custom fast-failure queues to be added in BrokerFastFailure [ISSUE #8348] Allow custom fast-failure queues to be added in BrokerFastFailure Jul 1, 2024
Copy link
Contributor

@guyinyou guyinyou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.12%. Comparing base (b31e0ce) to head (4669778).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8347      +/-   ##
=============================================
- Coverage      43.21%   43.12%   -0.09%     
+ Complexity     10526    10519       -7     
=============================================
  Files           1274     1274              
  Lines          88940    88941       +1     
  Branches       11434    11435       +1     
=============================================
- Hits           38433    38358      -75     
- Misses         45804    45870      +66     
- Partials        4703     4713      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -2519,4 +2519,6 @@ public ColdDataCgCtrService getColdDataCgCtrService() {
public void setColdDataCgCtrService(ColdDataCgCtrService coldDataCgCtrService) {
this.coldDataCgCtrService = coldDataCgCtrService;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line

@lizhimins lizhimins merged commit 9173def into apache:develop Jul 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Allow custom fast-failure queues to be added in BrokerFastFailure
6 participants