Revert elasticity commits - bug found with broadcast input #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ollback (apache#1625)" This reverts commit 2951193.
…when elasticity is enabled" This reverts commit eaf8252.
…ckpoint" This reverts commit 01c1c71.
…n envelope is finished processing when elasticity is enabled" This reverts commit 49354c6.
…ents" This reverts commit 603cfaa.
….enabled=true" This reverts commit cea7ab9.
…ases" This reverts commit 58af358.
…container starts up using checkpoints from previous deploys when elasticity was enabled" This reverts commit 2cda174.
…mplement for KafkaCheckpointManager" This reverts commit 400d197.
…me when elasticity is enabled" This reverts commit da75b63.
…oss elastic tasks (apache#1589)" This reverts commit f41d29c.
|
Let us document what part of elasticity is reverted and what still is in and what our plan is put these back on. |
mynameborat
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptom: broadcast input ssp is not consumed by all containers of the job.
cause: elasticity code changing systemconsumers and samza-core
changes:
test: build passes
Usage/upgrade: elasticity will not work
backwards compatible: yes, reverting code.
list of elasticity PRs being reverted -
#1625
#1610
#1608
#1607
#1603
#1598
#1597
#1596
#1589