Skip to content

SAMZA-2734: [Elasticity] Update last processed offset after an envelopepe is finished processing when elasticity is enabled#1607

Merged
rayman7718 merged 1 commit intoapache:masterfrom
lakshmi-manasa-g:elasticity-checkpoint-rw
May 17, 2022
Merged

SAMZA-2734: [Elasticity] Update last processed offset after an envelopepe is finished processing when elasticity is enabled#1607
rayman7718 merged 1 commit intoapache:masterfrom
lakshmi-manasa-g:elasticity-checkpoint-rw

Conversation

@lakshmi-manasa-g
Copy link
Contributor

Feature: Elasticity (SAMZA-2687) for a Samza job allows job to have more tasks than the number of input SystemStreamPartition(SSP). Thus, a job can scale up beyond its input partition count without needing the repartition the input stream.
This current PR is to update the last processed offsets maintained by the OffsetManager during processing stage of the container correctly when elasticity is enabled.

Changes:

  1. Modify OffsetManager.udpate to correctly identify the ssp even with keyBucket info is not present in the given parameter ssp
  2. Modify SystemConsumers to provide the ssp,offset to Chooser after all the registrations are done. This is because, chooser is given an ssp without keyBucket but a container could be processing multiple keyBuckets within the same ssp. So after registration for all is complete, the smallest offset is given to the chooser.

Tests: added unit test

API changes: no public api change

Upgrade instructions: none

Usage instructions: None.

Backwards compatible: yes. does not affect the existing flow

…pe is finished processing when elasticity is enabled
@rayman7718 rayman7718 merged commit 7dc3de5 into apache:master May 17, 2022
mynameborat pushed a commit that referenced this pull request Aug 4, 2022
Symptom: Broadcast input ssp is not consumed by all containers of the job.
Cause: Elasticity code changing systemconsumers and samza-core
Changes:

reverting all elasticity commits post SAMZA-2719: [Elasticity] fix container level metrics when elasticity is enabled #1585 after which this issue was detected.
updating the checkpointv1 serde to accept checkpoints written with SAMZA-2743: [Elasticity] Add keybucket into SSP serde for checkpoint #1608 

list of elasticity PRs being reverted -
#1625
#1610
#1608
#1607
#1603
#1598
#1597
#1596
#1589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants