Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAMZA-1408 update the branch doc for 0.13.1 release #286

Closed
wants to merge 2 commits into from

Conversation

fredji97
Copy link

No description provided.

Copy link
Contributor

@nickpan47 nickpan47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick git grep in 0.13.0 branch and noticed that there is additional files w/ 0.13.0 version marked:
{code}
localhost:samza_master yipan$ git grep '0.13.0' | grep 'docs/' | cut -d':' -f1
docs/learn/tutorials/versioned/hello-samza-high-level-yarn.md
docs/learn/tutorials/versioned/hello-samza-high-level-zk.md
docs/learn/tutorials/versioned/samza-rest-getting-started.md
docs/startup/hello-samza/versioned/index.md
docs/startup/preview/index.md
docs/startup/preview/index.md
docs/startup/preview/index.md
docs/startup/preview/index.md
docs/startup/preview/index.md
localhost:samza_master yipan$
{code}

Please check docs/learn/tutorials/versioned/samza-rest-getting-started.md and docs/startup/preview/index.md to see whether there is anything needs to be updated.

docs/_config.yml Outdated
@@ -23,6 +23,6 @@ redcarpet:
extensions: ['with_toc_data', 'smart']
exclude: [_docs]
baseurl: http://samza.apache.org
version: latest
version: 0.13.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need '' marks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we don't need change in the doc version since we never track the minor version docs in the release. We simply overwrite the previous 0.13.0 doc version w/ the new 0.13.1 under the same 0.13 version.

docs/_config.yml Outdated
@@ -23,6 +23,6 @@ redcarpet:
extensions: ['with_toc_data', 'smart']
exclude: [_docs]
baseurl: http://samza.apache.org
version: latest
version: 0.13.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we don't need change in the doc version since we never track the minor version docs in the release. We simply overwrite the previous 0.13.0 doc version w/ the new 0.13.1 under the same 0.13 version.

Copy link
Contributor

@nickpan47 nickpan47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

asfgit pushed a commit that referenced this pull request Aug 26, 2017
Author: Fred Ji <haifeng.ji@gmail.com>

Reviewers: Yi Pan <nickpan47@gmail.com>

Closes #286 from fredji97/0.13.1_doc and squashes the following commits:

0717974 [Fred Ji] SAMZA-1408 keep the doc unchanged for minor release and update PR based on feedback
774ee5f [Fred Ji] SAMZA-1408 update the branch doc for 0.13.1 release
@nickpan47
Copy link
Contributor

@fredji97 do we still need to merge this one? Or can one close it now?

@fredji97
Copy link
Author

fredji97 commented Jan 3, 2018

@nickpan47 this one was merged in the past for 0.13.1 release. we can close it now.

@fredji97 fredji97 closed this Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants