Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][IT]Solve the path problem when IT runs under windows #1855

Closed
wants to merge 0 commits into from

Conversation

tmljob
Copy link
Contributor

@tmljob tmljob commented May 11, 2022

Purpose of this pull request

Solve the path problem when IT runs under windows

Check list

@ruanwenjun
Copy link
Member

ruanwenjun commented May 11, 2022

I remember we find the testcontainer has problem on Windows, so in fact we will not run IT in Windows now, do you think if we need to support IT on Windows? @wuchunfu.

@tmljob
Copy link
Contributor Author

tmljob commented May 12, 2022

I remember we find the testcontainer has problem on Windows, so in fact we will not run IT in Windows now, do you think if we need to support IT on Windows? @wuchunfu.

I develop in the windows environment, and after developing the plug-in, I want to verify it through IT, so I think it is still meaningful for IT to run under windows, and there are problems that can be solved.

@tmljob
Copy link
Contributor Author

tmljob commented May 12, 2022 via email

@ruanwenjun
Copy link
Member

I remember we find the testcontainer has problem on Windows, so in fact we will not run IT in Windows now, do you think if we need to support IT on Windows? @wuchunfu.

I develop in the windows environment, and after developing the plug-in, I want to verify it through IT, so I think it is still meaningful for IT to run under windows, and there are problems that can be solved.

It would be great, if we can run IT on Windows, my concern is that can we able to solve this kind of problems, and maintain two environment will cost a lot of attention. But it would be better if you want to maintain this module.

@wuchunfu
Copy link
Member

I remember we find the testcontainer has problem on Windows, so in fact we will not run IT in Windows now, do you think if we need to support IT on Windows? @wuchunfu.

I develop in the windows environment, and after developing the plug-in, I want to verify it through IT, so I think it is still meaningful for IT to run under windows, and there are problems that can be solved.

It would be great, if we can run IT on Windows, my concern is that can we able to solve this kind of problems, and maintain two environment will cost a lot of attention. But it would be better if you want to maintain this module.

testcontainers doesn't seem to be supported in windows , so I'll remove this integration test first in ci , please refer to testcontainers/testcontainers-java#2960 and https://stackoverflow.com/questions/66077884/testcontainers-in-windows-environment-on-github-actions-could-not-find-a-valid , If you can fix that, that's the best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants