[Improve][Redis] Redis reader use scan cammnd instead of keys, single mode reader/writer support batch #7087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FuYouJ
changed the title
This was
linked to
issues
Jul 1, 2024
Hisoka-X
changed the title
Hisoka-X
reviewed
Jul 1, 2024
docs/en/connector-v2/sink/Redis.md
Outdated
Comment on lines
87
to
91
| > | ||
| > ### batch_size [int] | ||
| > | ||
| > Ensure the batch write size in single-machine mode; no guarantees in cluster mode. | ||
| > |
There was a problem hiding this comment.
Suggested change
| > | |
| > ### batch_size [int] | |
| > | |
| > Ensure the batch write size in single-machine mode; no guarantees in cluster mode. | |
| > | |
| ### batch_size [int] | |
| Ensure the batch write size in single-machine mode; no guarantees in cluster mode. | |
There was a problem hiding this comment.
Thank you. I was careless here
docs/en/connector-v2/source/Redis.md
Outdated
| @@ -113,6 +114,10 @@ each kv that in hash key it will be treated as a row and send it to upstream. | |||
|
|
|||
| keys pattern | |||
|
|
|||
| ### batch_size [int] | |||
|
|
|||
| indicates the number of keys to attempt to return per iteration.default 10 | |||
There was a problem hiding this comment.
Suggested change
| indicates the number of keys to attempt to return per iteration.default 10 | |
| indicates the number of keys to attempt to return per iteration, default 10 |
hailin0
approved these changes
Jul 3, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 10, 2024
… mode reader/writer support batch (apache#7087)
Thomas-HuWei
pushed a commit
to zilliztech/seatunnel
that referenced
this pull request
Jul 10, 2024
… mode reader/writer support batch (apache#7087)
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 13, 2024
… mode reader/writer support batch (apache#7087)
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
… mode reader/writer support batch (apache#7087)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note.