-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improve][Redis] Redis reader use scan cammnd instead of keys, single mode reader/writer support batch #7087
Conversation
docs/en/connector-v2/sink/Redis.md
Outdated
> | ||
> ### batch_size [int] | ||
> | ||
> Ensure the batch write size in single-machine mode; no guarantees in cluster mode. | ||
> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
> | |
> ### batch_size [int] | |
> | |
> Ensure the batch write size in single-machine mode; no guarantees in cluster mode. | |
> | |
### batch_size [int] | |
Ensure the batch write size in single-machine mode; no guarantees in cluster mode. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I was careless here
docs/en/connector-v2/source/Redis.md
Outdated
@@ -113,6 +114,10 @@ each kv that in hash key it will be treated as a row and send it to upstream. | |||
|
|||
keys pattern | |||
|
|||
### batch_size [int] | |||
|
|||
indicates the number of keys to attempt to return per iteration.default 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indicates the number of keys to attempt to return per iteration.default 10 | |
indicates the number of keys to attempt to return per iteration, default 10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Thanks @FuYouJ
… mode reader/writer support batch (apache#7087)
… mode reader/writer support batch (apache#7087)
… mode reader/writer support batch (apache#7087)
… mode reader/writer support batch (apache#7087)
Purpose of this pull request
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.