-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2][Clickhouse] Add clickhouse.config to the source connector #7143
Merged
EricJoy2048
merged 4 commits into
apache:dev
from
loustler:clickhouse-custom-config-source
Jul 9, 2024
Merged
[Feature][Connector-V2][Clickhouse] Add clickhouse.config to the source connector #7143
EricJoy2048
merged 4 commits into
apache:dev
from
loustler:clickhouse-custom-config-source
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hisoka-X
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @loustler !
EricJoy2048
approved these changes
Jul 9, 2024
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 10, 2024
…ce connector (apache#7143) * The source connector of Clickhouse support a custom clickhouse config * UPDATE doc * fmt --------- Co-authored-by: Dongyeon <loustler@naverz-corp.com>
Thomas-HuWei
pushed a commit
to zilliztech/seatunnel
that referenced
this pull request
Jul 10, 2024
…ce connector (apache#7143) * The source connector of Clickhouse support a custom clickhouse config * UPDATE doc * fmt --------- Co-authored-by: Dongyeon <loustler@naverz-corp.com>
Thomas-HuWei
pushed a commit
to zilliztech/seatunnel
that referenced
this pull request
Jul 10, 2024
…ce connector (apache#7143) * The source connector of Clickhouse support a custom clickhouse config * UPDATE doc * fmt --------- Co-authored-by: Dongyeon <loustler@naverz-corp.com>
hawk9821
pushed a commit
to hawk9821/seatunnel
that referenced
this pull request
Jul 13, 2024
…ce connector (apache#7143) * The source connector of Clickhouse support a custom clickhouse config * UPDATE doc * fmt --------- Co-authored-by: Dongyeon <loustler@naverz-corp.com>
chaorongzhi
pushed a commit
to chaorongzhi/seatunnel
that referenced
this pull request
Aug 21, 2024
…ce connector (apache#7143) * The source connector of Clickhouse support a custom clickhouse config * UPDATE doc * fmt --------- Co-authored-by: Dongyeon <loustler@naverz-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This pull request is add a new optional configuration
clickhouse.config
for the source connector of ClickHouse exactly same with the sink connector of ClickHouse.It relative #7109, and it will close #7109 if it merged.
Does this PR introduce any user-facing change?
NO, it's a new optional configuration for source connector of ClickHouse.
How was this patch tested?
Package the connector-clickhouse-2.3.5-2.12.15.jar, place it in a docker image, and complete the ClickHouse reading test
Check list
New License Guide
release-note
.