Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2][Clickhouse] Add clickhouse.config to the source connector #7143

Merged
merged 4 commits into from
Jul 9, 2024

Conversation

loustler
Copy link
Contributor

@loustler loustler commented Jul 9, 2024

Purpose of this pull request

This pull request is add a new optional configuration clickhouse.config for the source connector of ClickHouse exactly same with the sink connector of ClickHouse.

It relative #7109, and it will close #7109 if it merged.

Does this PR introduce any user-facing change?

NO, it's a new optional configuration for source connector of ClickHouse.

How was this patch tested?

Package the connector-clickhouse-2.3.5-2.12.15.jar, place it in a docker image, and complete the ClickHouse reading test

Check list

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @loustler !

@EricJoy2048 EricJoy2048 merged commit f7994d9 into apache:dev Jul 9, 2024
6 checks passed
@loustler loustler deleted the clickhouse-custom-config-source branch July 9, 2024 07:40
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 10, 2024
…ce connector (apache#7143)

* The source connector of Clickhouse support a custom clickhouse config

* UPDATE doc

* fmt

---------

Co-authored-by: Dongyeon <loustler@naverz-corp.com>
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
…ce connector (apache#7143)

* The source connector of Clickhouse support a custom clickhouse config

* UPDATE doc

* fmt

---------

Co-authored-by: Dongyeon <loustler@naverz-corp.com>
Thomas-HuWei pushed a commit to zilliztech/seatunnel that referenced this pull request Jul 10, 2024
…ce connector (apache#7143)

* The source connector of Clickhouse support a custom clickhouse config

* UPDATE doc

* fmt

---------

Co-authored-by: Dongyeon <loustler@naverz-corp.com>
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Jul 13, 2024
…ce connector (apache#7143)

* The source connector of Clickhouse support a custom clickhouse config

* UPDATE doc

* fmt

---------

Co-authored-by: Dongyeon <loustler@naverz-corp.com>
chaorongzhi pushed a commit to chaorongzhi/seatunnel that referenced this pull request Aug 21, 2024
…ce connector (apache#7143)

* The source connector of Clickhouse support a custom clickhouse config

* UPDATE doc

* fmt

---------

Co-authored-by: Dongyeon <loustler@naverz-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Connect-v2][Clickhouse] Support a custom clickhouse config for source side
3 participants