[SEDONA-476] Expose kepler & pydeck as extras #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiayuasu
changed the title
jiayuasu
approved these changes
Feb 1, 2024
|
Thank you for your contribution! |
jiayuasu
changed the title
jiayuasu
pushed a commit
that referenced
this pull request
Apr 28, 2024
* feat(python): expose kepler & pydeck optional dependencies in extras * feat(python): add `all` extras option * docs: update sql tutorial with new map extras
This was referenced May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[DOCS] my subject.What changes were proposed in this PR?
This updates the Sedona python package with three new extras:
kepler-map,pydeck-map, and anallextras.It also moves the import of the optional dependencies
keplerandpydeckinside the functions where they are used. This avoids logging unnecessary warnings like those described in #1222.How was this patch tested?
I tested the addition of the extras by doing local installs of the module in a virtual environment. The changes to
SedonaKeplerandSedonaPyDeckhave been tested in the CI.Did this PR include necessary documentation updates?