[SEDONA-556] Hidden requirement for geopandas in apache-sedona 1.5.2 #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kontinuation
approved these changes
May 9, 2024
jiayuasu
added a commit
that referenced
this pull request
May 9, 2024
freamdx
pushed a commit
to freamdx/sedona
that referenced
this pull request
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-556] my subject.What changes were proposed in this PR?
#1229 tried to eliminate the warning message of KeplerGL and DeckGL. This was done by removing the try-catch of import error message. This try-catch also hides the GeoPandas error accidentally in the past. The removal of this interception hence makes GeoPandas a required dependency.
This PR moves the
import geopandasstatement to the function that actually needs.How was this patch tested?
Passed local tests
Did this PR include necessary documentation updates?