Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] add glue tutorial #1453

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

james-willis
Copy link
Contributor

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

I am addressing this github issue: #1399

What changes were proposed in this PR?

This PR proposes adding an AWS Glue setup tutorial to the Sedona documentation website

How was this patch tested?

  • built and ran the docs site locally.
    Screenshot 2024-06-03 at 5 43 43 PM

  • followed the tutorial using the wherobots jars in an account other than the one hosting the jars bucket.

Did this PR include necessary documentation updates?

  • Yes, I have updated the documentation.

[Wherobots](https://wherobots.com/) provides a public S3 bucket with the necessary jars. You can point to these directly in your glue jobs'
configurations. For 1.6.0, the sedona and geotools jars are available at the following locations:

* `s3://wherobots-sedona-jars/1.6.0/sedona-spark-shaded-3.0_2.12-1.6.0.jar`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use the variable {{ sedona.current_version }} instead of hard coded version. See the example in other tutorial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we ensure that these are updated when a new version of sedona is released?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I will update the variable name after each release: https://github.com/apache/sedona/blob/master/mkdocs.yml#L161

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I mean the jars in the s3 bucket.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, someone needs to add it manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a release checklist or something to which we can add to ping me to update the bucket?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/setup/glue.md Outdated Show resolved Hide resolved
docs/setup/glue.md Outdated Show resolved Hide resolved
docs/setup/glue.md Outdated Show resolved Hide resolved
docs/setup/glue.md Show resolved Hide resolved
@jiayuasu jiayuasu merged commit 3960db8 into apache:master Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants