[SEDONA-617] Add ST_Rotate #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sedona-python
docs
sedona-flink
sedona-common
sedona-spark
sedona-snowflake
labels
|
@prantogg Can you also create a PR on |
furqaankhan
reviewed
Jun 25, 2024
Comment on lines
2292
to
2293
| !!!note | ||
| This function retains the z-index for 3D geometries and is compatible with Circular Strings, Curves, Polyhedral surfaces, Triangles, and Triangulated Irregular Network (TIN) surfaces. |
There was a problem hiding this comment.
I don't think we currently support all these types yet. @jiayuasu thoughts?
There was a problem hiding this comment.
I agree. @prantogg Can you explain why you put these here?
There was a problem hiding this comment.
Yes this is a documentation mistake. Fixed
jiayuasu
requested changes
Jun 26, 2024
Comment on lines
2292
to
2293
| !!!note | ||
| This function retains the z-index for 3D geometries and is compatible with Circular Strings, Curves, Polyhedral surfaces, Triangles, and Triangulated Irregular Network (TIN) surfaces. |
There was a problem hiding this comment.
I agree. @prantogg Can you explain why you put these here?
jiayuasu
approved these changes
Jun 27, 2024
Kontinuation
pushed a commit
to Kontinuation/sedona
that referenced
this pull request
Oct 11, 2024
* init * update scala test * add scala dataframeapi tests * add tests for flink * add tests for python * add tests for snowflake * add java tests * add docs * fix typo * fix python test * fix snowflake test * add ST_ReducePrecision for snowflake tests * fix tests * fix python implementation * Fix snowflake implementation * fix typo * Fix snowflake test * Fix snowflake test * Fix whitespaces in tests * fix docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-XXX] my subject.What changes were proposed in this PR?
How was this patch tested?
Did this PR include necessary documentation updates?
vX.Y.Zformat.