[SEDONA-211] Enforce release managers to use JDK 8 #724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
[SEDONA-211] my subject
.What changes were proposed in this PR?
My original thought was to use
<release>8</release>
in the POM. However, this leads to several issues<release>8</release>
compiler arg is only available on JDK >=9. We must set multiple POM profiles which only enables this release arg when JDK >=9 is detected on the release manager's environment.<release>8</release>
as default.Therefore, I added the instruction to the release manager doc to make sure that one must set mvn to JDK 8 when make a formal release.
If your Maven (
mvn --version
) points to other JDK versions, you must change it to JDK 8. Steps are as follows:/usr/libexec/java_home -V
. You should see multiple JDK versions including JDK 8.whereis mvn
to get the installation location of your Maven. The result is a symlink to the actual location.sudo
if needed). It will be like thisJAVA_HOME:-$(/usr/libexec/java_home)}
toJAVA_HOME:-$(/usr/libexec/java_home -v 1.8)}
. The resulting content will be like this:mvn --version
again. It should now point to JDK 8.How was this patch tested?
Did this PR include necessary documentation updates?