-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-244][SEDONA-246] R align spark_read/write functions #779
Conversation
DESCRIPTION cleanup: bump to dev version .9000, move dplyr to Suggests (never imported, a dependency of sparklyr anyway)
Fixes to documentation
More geoparquet tests (copied from scala tests)
Create functions Tests to read/write (based on java tests)
Some read and RS functions tests
Co-authored-by: zzs-wherobots <zzs-wherobots@ZongsideMac-Studio.local> Co-authored-by: Zongsi Zhang <zongsi@Zongsis-MacBook-Pro.local>
Adding test on multi-geom geoparquet
Using lifecycle (switch to markdown documentation) Soft deprecation warning for typed RDD functions
Fixed RS tests
Tweaks to tests
Fix arguments propagation for spark_write_geoparquet
Change way to count files in geotiff test
Changed test to accomodate bug in Spark 3.2.1 (can't reuse registered view names)
Also, man pages have so far not been committed to git. Which means i) someone needs to run BTW, the absence of man pages is the reason for one of the warnings in the GH Actions ("Warning: Undocumented code objects:" at the "Check" phase) |
Can you create a separate PR to upload the man page? I think this PR is ready to go. |
Sure |
https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-244
https://issues.apache.org/jira/projects/SEDONA/issues/SEDONA-246
What changes were proposed in this PR?
In the R package:
How was this patch tested?
Translated Scala tests for geoparquet and geotiff
Did this PR include necessary documentation updates?
R documentation only