Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]get sync value from context instead of directly from configuration file #257

Merged
merged 6 commits into from
Aug 20, 2022
Merged

[feat]get sync value from context instead of directly from configuration file #257

merged 6 commits into from
Aug 20, 2022

Conversation

kkf1
Copy link
Contributor

@kkf1 kkf1 commented Aug 19, 2022 •
edited by little-cui
Loading

  • 当前通过配置控制是否产生同步任务，会导致service层的依赖方只要调用此方法都会产生同步任务
  • 实际需求是，只有resource层下发的操作才需要产生同步任务，故改为通过context传值判断

little-cui
little-cui requested changes Aug 19, 2022
View reviewed changes
server/service/kv/kv_svc.go Outdated Show resolved Hide resolved
@little-cui little-cui changed the title get sync value from context instead of directly from configuration file [feat]get sync value from context instead of directly from configuration file Aug 20, 2022
@little-cui little-cui merged commit c2eaf67 into apache:master Aug 20, 2022
@kkf1 kkf1 deleted the nzx branch August 24, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianxiaoliang tianxiaoliang tianxiaoliang left review comments

@little-cui little-cui little-cui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkf1 @tianxiaoliang @little-cui