Get service from cache first (#1066) #1067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuziye01
changed the title
DFSOrange
reviewed
Jun 23, 2021
| "go.mongodb.org/mongo-driver/bson" | ||
| ) | ||
|
|
||
| func GetServiceByID(ctx context.Context, serviceID string) (*model.Service, error) { |
There was a problem hiding this comment.
最早的版本有一层单独访问缓存再查db的逻辑，后来讨论过特地取消的。
fuziye01
force-pushed
the
master
branch
5 times, most recently
from
d030fc0
to
2e8112a
Compare
|
冲突了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
【issue】: #1066
【特性/模块名称】：缓存优化
【修改内容】：
1.所有查询service的地方都由从db查询修改为先从缓存中查询，如果缓存中没有再查db
根据version版本匹配的地方暂未修改，后续实现了缓存version匹配再修改
2.service缓存key由原来的{serviceID}修改为{domain}/{project}/{serviceID}的形式
否则多域下出现serviceID相同的情况查询会有问题
【自测情况】：
测试通过