Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Guava Strings class instead of assertj Strings class #1077

Merged
merged 3 commits into from Jul 15, 2020
Merged

Use Guava Strings class instead of assertj Strings class #1077

merged 3 commits into from Jul 15, 2020

Conversation

zhaoyuguang
Copy link
Member

Fixes #1076

dongzl
dongzl requested changes Jul 15, 2020
View reviewed changes
...ain/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java Outdated
@@ -50,9 +50,9 @@
@EnableConfigurationProperties(ElasticJobProperties.class)
@Setter
public class ElasticJobLiteAutoConfiguration implements ApplicationContextAware {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the white space.

...ain/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java Outdated
private ApplicationContext applicationContext;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the white space.

...ain/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java Outdated
@@ -68,7 +68,7 @@ public void createJobBootstrapBeans() throws ClassNotFoundException {
registerClassedJobs(elasticJobProperties, beanFactory, registryCenter, tracingConfiguration);
registerTypedJobs(elasticJobProperties, beanFactory, registryCenter, tracingConfiguration);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same to above.

...ain/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java Outdated
@@ -81,7 +81,7 @@ private TracingConfiguration getTracingConfiguration() {
"More than one [org.apache.shardingsphere.elasticjob.tracing.api.TracingConfiguration] beans found. "
+ "Consider disabling [org.apache.shardingsphere.elasticjob.tracing.boot.ElasticjobTracingAutoConfiguration].");
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same to above.

...ain/java/org/apache/shardingsphere/elasticjob/lite/boot/ElasticJobLiteAutoConfiguration.java Outdated
@@ -97,8 +97,8 @@ private void registerClassedJobs(final ElasticJobProperties elasticJobProperties
}
}
}

private void registerTypedJobs(final ElasticJobProperties elasticJobProperties, final SingletonBeanRegistry beanFactory,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same to above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had fixed

@terrymanu terrymanu added this to the 3.0.0 milestone Jul 15, 2020
@dongzl dongzl merged commit 287f01f into apache:master Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongzl dongzl dongzl requested changes

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
3.0.0-alpha
Development

Successfully merging this pull request may close these issues.

Use Guava Strings class instead of assertj Strings class.
3 participants
@zhaoyuguang @terrymanu @dongzl