-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job identification strategy. (#472) #1106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terrymanu
requested changes
Jul 17, 2020
...g/apache/shardingsphere/elasticjob/lite/internal/setup/JobIdentificationStrategyFactory.java
Outdated
Show resolved
Hide resolved
...g/apache/shardingsphere/elasticjob/lite/internal/setup/JobIdentificationStrategyFactory.java
Outdated
Show resolved
Hide resolved
...apache/shardingsphere/elasticjob/lite/internal/setup/JobClassNameIdentificationStrategy.java
Outdated
Show resolved
Hide resolved
public class JobClassNameBySpringIdentificationStrategy implements JobIdentificationStrategy { | ||
|
||
@Override | ||
public String identify(final ElasticJob elasticJob, final String jobName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should return Optional for next JobIdentificationStrategy, just like response chain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, I'll finish it in the next PR.
.../services/org.apache.shardingsphere.elasticjob.lite.internal.setup.JobIdentificationStrategy
Outdated
Show resolved
Hide resolved
...apache/shardingsphere/elasticjob/lite/spring/setup/JobIdentificationStrategyFactoryTest.java
Outdated
Show resolved
Hide resolved
terrymanu
approved these changes
Jul 18, 2020
...main/java/org/apache/shardingsphere/elasticjob/lite/internal/setup/JobClassNameProvider.java
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #472.