Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTP job #1345

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Support HTTP job #1345

merged 2 commits into from
Aug 10, 2020

Conversation

Technoboy-
Copy link
Contributor

Fixes #1339.

@Technoboy-
Copy link
Contributor Author

Add three new classes, HttpJobExecutor&HttpParam&HttpJobProperties.
HttpJobExecutor has added test -- HttpJobExecutorTest with 95% coverage.
HttpParam and HttpJobProperties are pojo without test case, so total coverage decreases.

terrymanu
terrymanu requested changes Aug 10, 2020
View reviewed changes
Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we consider about use apache httpclient or okhttp to simplify code or improve the performance?

elasticjob-executor/elasticjob-executor-type/elasticjob-http-executor/pom.xml Outdated Show resolved Hide resolved
...ob-http-executor/src/main/java/org/apache/shardingsphere/elasticjob/http/pojo/HttpParam.java Show resolved Hide resolved
...ob-http-executor/src/main/java/org/apache/shardingsphere/elasticjob/http/pojo/HttpParam.java Outdated Show resolved Hide resolved
...ob-http-executor/src/main/java/org/apache/shardingsphere/elasticjob/http/pojo/HttpParam.java Outdated Show resolved Hide resolved
...ecutor/src/main/java/org/apache/shardingsphere/elasticjob/http/executor/HttpJobExecutor.java Show resolved Hide resolved
...ecutor/src/main/java/org/apache/shardingsphere/elasticjob/http/executor/HttpJobExecutor.java Outdated Show resolved Hide resolved
...ecutor/src/main/java/org/apache/shardingsphere/elasticjob/http/executor/HttpJobExecutor.java Outdated Show resolved Hide resolved
viviel
viviel reviewed Aug 10, 2020
View reviewed changes
Copy link
Contributor

@viviel viviel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha, that's greate

TeslaCN
TeslaCN reviewed Aug 10, 2020
View reviewed changes
Copy link
Member

@TeslaCN TeslaCN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not support other HTTP method?

@Technoboy-
Copy link
Contributor Author

Why not support other HTTP method?

Hi, with this update, we support all http method.

@terrymanu terrymanu added this to the 3.0.0-beta milestone Aug 10, 2020
@terrymanu terrymanu merged commit a21a63e into apache:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeslaCN TeslaCN TeslaCN left review comments

@viviel viviel viviel left review comments

@terrymanu terrymanu terrymanu approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
3.0.0-beta
Development

Successfully merging this pull request may close these issues.

Support HTTP job
4 participants
@Technoboy- @terrymanu @TeslaCN @viviel