Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only leader can set resharding flag #1472

Merged
merged 1 commit into from Sep 21, 2020
Merged

Conversation

TeslaCN
Copy link
Member

@TeslaCN TeslaCN commented Sep 19, 2020

Fixes #1471 .

Changes proposed in this pull request:

  • Only leader can set resharding flag.
  • There is no need to setReshardingFlag when registerStartUpInfo because the listeners have already started.

@terrymanu terrymanu added this to the 3.0.0-beta milestone Sep 21, 2020
@terrymanu terrymanu merged commit 724c8d4 into apache:master Sep 21, 2020
luky116 pushed a commit to luky116/shardingsphere-elasticjob that referenced this pull request Sep 21, 2020
* Only leader can set resharding flag (apache#1472)

* updates

Co-authored-by: 吴伟杰 <root496879118@me.com>
@TeslaCN TeslaCN deleted the fixes-1471 branch September 22, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The shards which assigned to non-leader instances may not be executed in specific scenario
2 participants