fix issue#2014, autowire OneOffJobBootstrap failed. #2306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#2014
Changes proposed in this pull request:
cause of issue:
the bean which is registered in method afterSingletonsInstantiated can't be autowired, because autowire is earlier than afterSingletonsInstantiated which is executed by AutowiredAnnotationBeanPostProcessor.
solution:
OneOffBootStrap need to be register before autowire phase, and AutowiredAnnotationBeanPostProcessor is MergedBeanDefinitionPostProcessor bean, so ElasticJobBootstrapConfiguration need to be a MergedBeanDefinitionPostProcessor bean too, and OneOffBootStrap should be registered after ElasticJobBootstrapConfiguration initialized immediately.