Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit test for ShardingConditions #13821

Closed
4 tasks
strongduanmu opened this issue Nov 26, 2021 · 7 comments · Fixed by #15130
Closed
4 tasks

Add more unit test for ShardingConditions #13821

strongduanmu opened this issue Nov 26, 2021 · 7 comments · Fixed by #15130
Assignees
@farmer-it-1024 @chenlong1993
Labels
good first issue in: test
Milestone
5.1.1

Comments

@strongduanmu
Copy link
Member

Hi, community:

This issue is to add more unit tests for the ShardingConditions class. Welcome to claim them.

The specific subtasks are as follows:

  • Add unit test for ShardingConditions#isAlwaysFalse
  • Add unit test for ShardingConditions#merge
  • Add unit test for ShardingConditions#isNeedMerge
  • Add unit test for ShardingConditions#isSameShardingCondition

Through this issue, you can understand the process of participating in Apache ShardingSphere, and be familiar with sharding.
@strongduanmu strongduanmu added this to the 5.0.1 milestone Nov 26, 2021
@mohitsaxenaknoldus
Copy link

Please assign it to me, I'll do it.

@strongduanmu
Copy link
Member Author

@mohitsaxenaknoldus Welcome, I will assign this issue to you.

@mohitsaxenaknoldus mohitsaxenaknoldus mentioned this issue Nov 28, 2021
Closed
@mohitsaxenaknoldus
Copy link

@strongduanmu Need some help with this: #13836
Can't seem to figure out why the CI is failing.

@chenlong1993
Copy link
Contributor

I want solve this

@strongduanmu
Copy link
Member Author

I want solve this

@clbigdata Welcome, I will assign this issue to you.

@menghaoranss menghaoranss modified the milestones: 5.1.0, 5.1.1 Dec 27, 2021
@farmer-it-1024
Copy link
Contributor

Please assign this issue to me.thx

@strongduanmu
Copy link
Member Author

@farmer-liuz1024 Welcome, I just assign this issue to you.

@mohitsaxenaknoldus mohitsaxenaknoldus removed their assignment Jan 10, 2022
farmer-it-1024 added a commit to farmer-it-1024/shardingsphere that referenced this issue Jan 27, 2022
@farmer-it-1024
ShardingConditions and test cases (apache#13821)
dbf9c76
@farmer-it-1024 farmer-it-1024 mentioned this issue Jan 27, 2022
Merged
totalo pushed a commit that referenced this issue Feb 11, 2022
@farmer-it-1024
ShardingConditions and test cases (#13821) (#15130)
4f16161 
* ShardingConditions and test cases (#13821)

* 1. add licenses  2. optimize the code

* Optimize the code

* fix problems

* fix problems

* optimize code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@farmer-it-1024 farmer-it-1024

@chenlong1993 chenlong1993

Labels
good first issue in: test
Projects
None yet
Milestone
5.1.1
5 participants
@farmer-it-1024 @strongduanmu @chenlong1993 @menghaoranss @mohitsaxenaknoldus