Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock get/set networkTimeout of java.sql.Connection in JDBC Driver to prevent HikariCP's Warning #33024

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Sep 27, 2024

For #32765 (comment) .

Changes proposed in this pull request:

    @Test
    public void test() throws SocketException {
        int soTimeout = org.apache.http.conn.scheme.PlainSocketFactory.getSocketFactory().createSocket().getSoTimeout();
        System.out.println(soTimeout);
    }
13:01:12.583 [main] INFO com.zaxxer.hikari.pool.PoolBase - HikariPool-1 - Driver does not support get/set network timeout for connections. (getNetworkTimeout)

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@RaigorJiang RaigorJiang merged commit f00702e into apache:master Sep 27, 2024
141 checks passed
@linghengqian linghengqian deleted the fix-hikaricp branch September 27, 2024 06:41
terrymanu added a commit to terrymanu/shardingsphere that referenced this pull request Sep 27, 2024
terrymanu added a commit to terrymanu/shardingsphere that referenced this pull request Sep 27, 2024
strongduanmu pushed a commit that referenced this pull request Sep 27, 2024
* Revise #33024

* Revise #33024
terrymanu added a commit that referenced this pull request Sep 27, 2024
* Revise #33024

* Revise #33024

* Refactor YamlRuleConfigurationUnmarshalIT

* Refactor YamlRuleConfigurationUnmarshalIT

* Refactor YamlRuleConfigurationUnmarshalIT

* Refactor YamlRuleConfigurationUnmarshalIT

* Refactor YamlRuleConfigurationUnmarshalIT

* Refactor YamlRuleConfigurationUnmarshalIT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HikariCP Warning: "Driver does not support get/set network timeout for connections"
2 participants