add visitor for setVariable of mysql #4228

jingshanglu · 2020-02-10T12:09:28Z

Changes proposed in this pull request:

add visitor for setVariable
add visitor for showOther
add test for showColumus, setVariable,showCreateTable

codecov-io · 2020-02-10T12:34:39Z

Codecov Report

❗ No coverage uploaded for pull request base (master@ec7dde4). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4228   +/-   ##
=========================================
  Coverage          ?   60.76%           
  Complexity        ?      352           
=========================================
  Files             ?     1013           
  Lines             ?    17036           
  Branches          ?     3005           
=========================================
  Hits              ?    10352           
  Misses            ?     6031           
  Partials          ?      653

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec7dde4...9586ecb. Read the comment docs.

coveralls · 2020-02-10T12:42:01Z

Pull Request Test Coverage Report for Build 9435

0 of 15 (0.0%) changed or added relevant lines in 3 files are covered.
302 unchanged lines in 29 files lost coverage.
Overall coverage increased (+0.2%) to 64.657%

Changes Missing Coverage	Changed/Added Lines	%
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/SetStatement.java	1	0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/FromTableSegment.java	1	0.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java	13	0.0%

Files with Coverage Reduction	New Missed Lines	%
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/AuthenticationChangedListener.java	1	75.0%
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/PropertiesChangedListener.java	1	75.0%
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/config/listener/SchemaChangedListener.java	1	97.5%
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/DataSourceStateChangedListener.java	1	85.71%
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/registry/state/listener/InstanceStateChangedListener.java	1	75.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/column/ColumnSegment.java	1	50.0%
sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-namespace/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/datasource/OrchestrationSpringEncryptDataSource.java	1	50.0%
sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-namespace/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/datasource/OrchestrationSpringMasterSlaveDataSource.java	1	50.0%
sharding-spring/sharding-jdbc-orchestration-spring/sharding-jdbc-orchestration-spring-namespace/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/spring/datasource/OrchestrationSpringShardingDataSource.java	1	50.0%
shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/schema/SchemaExtractor.java	2	66.67%

Totals
Change from base Build 9428:	0.2%
Covered Lines:	11015
Relevant Lines:	17036

💛 - Coveralls

terrymanu

The comment Fixes #3914 will close the #3914, but the issue is not finished yet.

tristaZero · 2020-02-10T14:42:02Z

@terrymanu Hi, i guess you are reviewing this PR, so is it necessary for me to give it a look?

.../java/org/apache/shardingsphere/sql/parser/sql/statement/dal/dialect/mysql/SetStatement.java

terrymanu · 2020-02-10T14:35:39Z

.../src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java

+
+@RequiredArgsConstructor
+@Getter
+public class VariableExprSegment implements SQLSegment {


Missing java doc

Can the class be final?

terrymanu · 2020-02-10T14:36:04Z

.../src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java

+    private final String variable;
+
+    private final String expr;
+


Unnecessary blank lines

terrymanu · 2020-02-10T14:37:08Z

.../src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java

+
+@RequiredArgsConstructor
+@Getter
+public class VariableExprSegment implements SQLSegment {


We prefer do not use abbreviation.
Please rename expr to expression

terrymanu · 2020-02-10T14:37:14Z

.../src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dal/VariableExprSegment.java

+
+    private final String variable;
+
+    private final String expr;


We prefer do not use abbreviation.
Please rename expr to expression

terrymanu · 2020-02-10T14:45:16Z

...rdingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java

+import java.util.List;
+
+/**
+ * set variable statement test case.


First letter of java doc should be upper case.

terrymanu · 2020-02-10T14:45:46Z

...rdingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java

+@Setter
+public final class SetVariableStatementTestCase extends SQLParserTestCase {
+
+    @XmlElement(name = "variable-expr")


Please do not use abbreviation, please rename variable-expr to variable-expression

terrymanu · 2020-02-10T14:46:12Z

...rdingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java

+
+

Please remove unnecessary blank lines.

terrymanu · 2020-02-10T14:46:48Z

...rdingsphere/sql/parser/integrate/jaxb/domain/statement/dal/ShowColumnsStatementTestCase.java

+
+

Please remove unnecessary blank lines.

shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dal/show.xml

jingshanglu · 2020-02-11T02:06:02Z

The comment Fixes #3914 will close the #3914, but the issue is not finished yet.

@terrymanu What should be written？

terrymanu · 2020-02-11T03:38:10Z

The comment Fixes #3914 will close the #3914, but the issue is not finished yet.

@terrymanu What should be written？

Maybe For #3914 or just #3914

terrymanu

There are still some place need to be fix, but we have not time to waiting.
Because of the PR I wrote will conflict with this PR.

I will merge and revise it for next PR, please pay attention.

terrymanu · 2020-02-11T05:14:58Z

Please pay attention for #4233

Ternence added 2 commits February 10, 2020 19:58

add visitor for setvariable

ec7dde4

merge from upstram/master

1690f20

jingshanglu requested review from terrymanu and tristaZero and removed request for terrymanu February 10, 2020 12:15

terrymanu self-requested a review February 10, 2020 14:33

terrymanu requested changes Feb 10, 2020

View reviewed changes

tristaZero approved these changes Feb 10, 2020

View reviewed changes

terrymanu requested changes Feb 10, 2020

View reviewed changes

fix for code style

9586ecb

jingshanglu requested a review from terrymanu February 11, 2020 04:07

terrymanu approved these changes Feb 11, 2020

View reviewed changes

terrymanu added this to the 5.0.0 milestone Feb 11, 2020

terrymanu added type: enhancement in: SQL parse labels Feb 11, 2020

terrymanu merged commit 655d4a0 into apache:master Feb 11, 2020

terrymanu mentioned this pull request Feb 11, 2020

Revise #4228 #4233

Merged

tuohai666 pushed a commit that referenced this pull request Feb 11, 2020

revise #4228 (#4233)

12a628a

jingshanglu mentioned this pull request Feb 12, 2020

revert for setvariable of mysql DALStatement.g4 #4264

Merged

terrymanu modified the milestones: 5.0.0, 4.1.0 Mar 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add visitor for setVariable of mysql #4228

add visitor for setVariable of mysql #4228

jingshanglu commented Feb 10, 2020 •

edited by terrymanu

codecov-io commented Feb 10, 2020 •

edited

coveralls commented Feb 10, 2020 •

edited

terrymanu left a comment

tristaZero commented Feb 10, 2020 •

edited

terrymanu Feb 10, 2020

terrymanu Feb 10, 2020

terrymanu Feb 10, 2020

terrymanu Feb 10, 2020

terrymanu Feb 10, 2020

terrymanu Feb 10, 2020

terrymanu Feb 10, 2020

terrymanu Feb 10, 2020

jingshanglu commented Feb 11, 2020

terrymanu commented Feb 11, 2020

terrymanu left a comment

terrymanu commented Feb 11, 2020

add visitor for setVariable of mysql #4228

add visitor for setVariable of mysql #4228

Conversation

jingshanglu commented Feb 10, 2020 • edited by terrymanu

codecov-io commented Feb 10, 2020 • edited

Codecov Report

coveralls commented Feb 10, 2020 • edited

Pull Request Test Coverage Report for Build 9435

💛 - Coveralls

terrymanu left a comment

Choose a reason for hiding this comment

tristaZero commented Feb 10, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jingshanglu commented Feb 11, 2020

terrymanu commented Feb 11, 2020

terrymanu left a comment

Choose a reason for hiding this comment

terrymanu commented Feb 11, 2020

jingshanglu commented Feb 10, 2020 •

edited by terrymanu

codecov-io commented Feb 10, 2020 •

edited

coveralls commented Feb 10, 2020 •

edited

tristaZero commented Feb 10, 2020 •

edited