Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert for setvariable of mysql DALStatement.g4 #4264

Merged
merged 5 commits into from
Feb 12, 2020
Merged

revert for setvariable of mysql DALStatement.g4 #4264

merged 5 commits into from
Feb 12, 2020

Conversation

jingshanglu
Copy link
Contributor

revert for #4228 .

Changes proposed in this pull request:

  • revert for setvariable of mysql DALStatement.g4

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9478

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 64.815%
Changes Missing Coverage Covered Lines Changed/Added Lines %
shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDALVisitor.java 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java 3 76.0%
Totals Coverage Status
Change from base Build 829: 0.3%
Covered Lines: 11025
Relevant Lines: 17010
💛 - Coveralls

@terrymanu terrymanu self-requested a review February 12, 2020 10:05
@terrymanu terrymanu merged commit ad11519 into apache:master Feb 12, 2020
@terrymanu terrymanu added this to the 5.0.0 milestone Feb 12, 2020
@terrymanu terrymanu modified the milestones: 5.0.0, 4.1.0 Mar 18, 2020
@jingshanglu jingshanglu deleted the issue-1 branch May 27, 2020 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrymanu terrymanu terrymanu approved these changes

@tristaZero tristaZero Awaiting requested review from tristaZero

Assignees
No one assigned
Labels
in: SQL parse type: refactor
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jingshanglu @coveralls @terrymanu