-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4345] Add support for polaris config sync #4410
Conversation
As for support pushing configuration to Polaris: The polaris client does not contain a method to publish the config to Polaris. package org.apache.shenyu.admin.listener.polaris;
@Override
public void publishConfig(String dataId, Object data) {
LOG.warn("Config upload not support yet, please upload it in polaris first");
} So if we change on the admin dashboard only, it can not sync to Polaris and the bootstrap application. |
Codecov Report
@@ Coverage Diff @@
## master #4410 +/- ##
============================================
+ Coverage 63.89% 63.98% +0.08%
- Complexity 8235 8291 +56
============================================
Files 1169 1177 +8
Lines 34541 34725 +184
Branches 3107 3111 +4
============================================
+ Hits 22071 22219 +148
- Misses 10706 10734 +28
- Partials 1764 1772 +8
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Now, Polaris-java SDK hasn't supported the sync config. But there is the other way to sync. |
Pls add my WeChat(id: Fibonacci_stack), there is a group to support Polaris. |
Thanks for that, let me see what I can do.💪 |
…d_support_for_polaris
It is officially released now. |
…d_support_for_polaris
# Conflicts: # shenyu-admin/src/main/java/org/apache/shenyu/admin/config/DataSyncConfiguration.java
The rest parts looks fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls @mahaitao617 review.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true
.TODO:
Related issue: #4345
ShenYu admin
Use polaris-sync to sync config.Add method for upsert config file polarismesh/polaris-java#341ShenYu bootstarap