Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3949] support Tencent Polaris Registration Center #4897

Merged
merged 23 commits into from
Jul 25, 2023

Conversation

damonxue
Copy link
Contributor

@damonxue damonxue commented Jul 25, 2023

As for support pushing configuration to Polaris:
#3949 .
And pr.#4410 #4410

  • Add shenyu-register-client-server/shenyu-register-client-server-polaris module .
  • Add shenyu-register-client/shenyu-register-client-polaris module .
  • Add shenyu-register-instance/shenyu-register-instance-polaris module .
  • Add shenyu-sync-data-center/shenyu-sync-data-polaris module .
  • Add shenyu-spring-boot-starter/shenyu-spring-boot-starter-sync-data-center/shenyu-spring-boot-starter-sync-data-polaris module .

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

fengbiao and others added 21 commits February 27, 2023 20:46
# Conflicts:
#	pom.xml
#	shenyu-register-center/shenyu-register-client-server/pom.xml
#	shenyu-register-center/shenyu-register-client/pom.xml
# Conflicts:
#	shenyu-registry/pom.xml
#	shenyu-registry/shenyu-register-instance-polaris/pom.xml
#	shenyu-registry/shenyu-register-instance-polaris/src/main/java/org/apache/shenyu/register/instance/polaris/PolarisInstanceRegisterRepository.java
#	shenyu-registry/shenyu-register-instance-polaris/src/main/resources/META-INF/shenyu/org.apache.shenyu.register.instance.api.ShenyuInstanceRegisterRepository
#	shenyu-registry/shenyu-register-instance-polaris/src/test/java/org/apache/shenyu/register/instance/polaris/PolarisInstanceRegisterRepositoryTest.java
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #4897 (e29f420) into master (39db11b) will increase coverage by 0.02%.
The diff coverage is 70.50%.

@@             Coverage Diff              @@
##             master    #4897      +/-   ##
============================================
+ Coverage     64.01%   64.04%   +0.02%     
- Complexity     8301     8324      +23     
============================================
  Files          1177     1180       +3     
  Lines         34725    34864     +139     
  Branches       3111     3115       +4     
============================================
+ Hits          22229    22328      +99     
- Misses        10723    10763      +40     
  Partials       1773     1773              
Files Changed Coverage Δ
...try/polaris/PolarisInstanceRegisterRepository.java 56.52% <56.52%> (ø)
...polaris/PolarisClientServerRegisterRepository.java 61.90% <61.90%> (ø)
...lient/polaris/PolarisClientRegisterRepository.java 90.19% <90.19%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@damonxue
Copy link
Contributor Author

@dragon-zhang @mahaitao617 pls review.

@moremind
Copy link
Member

pls add license file

@moremind moremind merged commit 2a416d5 into apache:master Jul 25, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants