-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #3949] support Tencent Polaris Registration Center #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml # shenyu-register-center/shenyu-register-client-server/pom.xml # shenyu-register-center/shenyu-register-client/pom.xml
# Conflicts: # shenyu-registry/pom.xml # shenyu-registry/shenyu-register-instance-polaris/pom.xml # shenyu-registry/shenyu-register-instance-polaris/src/main/java/org/apache/shenyu/register/instance/polaris/PolarisInstanceRegisterRepository.java # shenyu-registry/shenyu-register-instance-polaris/src/main/resources/META-INF/shenyu/org.apache.shenyu.register.instance.api.ShenyuInstanceRegisterRepository # shenyu-registry/shenyu-register-instance-polaris/src/test/java/org/apache/shenyu/register/instance/polaris/PolarisInstanceRegisterRepositoryTest.java
Codecov Report
@@ Coverage Diff @@
## master #4897 +/- ##
============================================
+ Coverage 64.01% 64.04% +0.02%
- Complexity 8301 8324 +23
============================================
Files 1177 1180 +3
Lines 34725 34864 +139
Branches 3111 3115 +4
============================================
+ Hits 22229 22328 +99
- Misses 10723 10763 +40
Partials 1773 1773
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@dragon-zhang @mahaitao617 pls review. |
moremind
requested changes
Jul 25, 2023
...aris/src/main/java/org/apache/shenyu/registry/polaris/PolarisInstanceRegisterRepository.java
Show resolved
Hide resolved
pls add license file |
moremind
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As for support pushing configuration to Polaris:
#3949 .
And pr.#4410 #4410
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true
.