Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4182] optimization global plugin sort. #4429

Merged
merged 5 commits into from
Mar 29, 2023

Conversation

iwangjie
Copy link
Contributor

@iwangjie iwangjie commented Mar 4, 2023

  1. GLOBAL order set -1
  2. PluginDTO sort add @min(0)

image

Make sure that:

  • You have read the contribution guidelines.
  • You submit test cases (unit or integration tests) that back your changes.
  • Your local test passed ./mvnw clean install -Dmaven.javadoc.skip=true.

@qicz
Copy link
Member

qicz commented Mar 22, 2023

@iwangjie pls check ci & resolve conflict

@iwangjie
Copy link
Contributor Author

@iwangjie pls check ci & resolve conflict

ok.

@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #4429 (d2562ef) into master (0a777ec) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #4429      +/-   ##
============================================
- Coverage     68.43%   68.42%   -0.02%     
+ Complexity     7616     7614       -2     
============================================
  Files          1029     1029              
  Lines         29403    29403              
  Branches       2659     2659              
============================================
- Hits          20123    20118       -5     
- Misses         7690     7694       +4     
- Partials       1590     1591       +1     
Impacted Files Coverage Δ
...a/org/apache/shenyu/admin/model/dto/PluginDTO.java 62.16% <ø> (ø)
...ava/org/apache/shenyu/common/enums/PluginEnum.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@li-keguo li-keguo merged commit 3d8798b into apache:master Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants