-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix api document module update api detail error #4720
Conversation
@@ -113,6 +113,7 @@ private String update(final ApiDTO apiDTO) { | |||
.id(UUIDUtils.getInstance().generateShortUuid()) | |||
.apiId(apiDO.getId()) | |||
.tagId(tagId) | |||
.dateCreated(currentTime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the SQL statement, changing the create time in the update interface is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the SQL statement, changing the create time in the update interface is incorrect.
tagRelationMapper.deleteByApiId(apiDO.getId());
tagRelationMapper.batchInsert(tags);
hi, but due the tag relation always be deleted and then insert new tag relation when update this api, the createdTime always is currentTime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, I saw that.
Codecov Report
@@ Coverage Diff @@
## master #4720 +/- ##
============================================
- Coverage 66.27% 66.27% -0.01%
- Complexity 8010 8011 +1
============================================
Files 1111 1111
Lines 32181 32182 +1
Branches 2907 2907
============================================
Hits 21329 21329
- Misses 9154 9155 +1
Partials 1698 1698
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bugfix can not update api detail on api document module.
exception below happen when update api detail.
Make sure that:
./mvnw clean install -Dmaven.javadoc.skip=true
.