Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type Refactor]client register base(Combination is better than inheritance) #4809

Merged
merged 7 commits into from Jul 6, 2023

Conversation

li-keguo
Copy link
Member

@li-keguo li-keguo commented Jul 5, 2023

about issue #4806

Following the idea that combination is better than inheritance, the extension of registration is changed to the combined way

Make sure that:

  • Design the registrar implementation to implement three types of metadata registration
  • Design processor and AP Ibean state mechanisms
  • Implements simple API Doc registration, supports original annotation and no-annotation mode

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #4809 (da04acf) into master (8d4bfa0) will decrease coverage by 0.57%.
The diff coverage is 4.01%.

@@             Coverage Diff              @@
##             master    #4809      +/-   ##
============================================
- Coverage     65.32%   64.76%   -0.57%     
+ Complexity     8186     8183       -3     
============================================
  Files          1138     1147       +9     
  Lines         33476    33775     +299     
  Branches       2975     3013      +38     
============================================
+ Hits          21867    21873       +6     
- Misses         9885    10175     +290     
- Partials       1724     1727       +3     
Impacted Files Coverage Δ
...ent/core/register/matcher/ApiDocProcessorImpl.java 0.00% <0.00%> (ø)
...nyu/client/core/register/matcher/ApiProcessor.java 0.00% <0.00%> (ø)
...e/register/matcher/BaseAnnotationApiProcessor.java 0.00% <0.00%> (ø)
...re/register/registrar/ApiDocRegistrarImplImpl.java 0.00% <0.00%> (ø)
.../core/register/registrar/BaseApiRegistrarImpl.java 0.00% <0.00%> (ø)
...gister/registrar/MateDataApiRegistrarImplImpl.java 0.00% <0.00%> (ø)
...re/register/registrar/UriApiRegistrarImplImpl.java 0.00% <0.00%> (ø)
...g/apache/shenyu/client/core/utils/ApiBeanUtil.java 0.00% <0.00%> (ø)
...c/register/ShenyuSpringMvcClientProcessorImpl.java 0.00% <0.00%> (ø)
...rg/apache/shenyu/client/core/register/ApiBean.java 50.00% <57.14%> (+1.16%) ⬆️
... and 1 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tian-pengfei tian-pengfei merged commit 9e854dc into apache:master Jul 6, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants