[ISSUE #4686] ZookeeperClientRegisterRepository active offline

[xuziyang]

[ISSUE #4686] ZookeeperClientRegisterRepository active offline

[codecov-commenter]

Codecov Report

Merging #4806 (015e3d0) into master (9e854dc) will increase coverage by 0.09%.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #4806      +/-   ##
============================================
+ Coverage     64.51%   64.60%   +0.09%     
- Complexity     8167     8173       +6     
============================================
  Files          1147     1147              
  Lines         33775    33773       -2     
  Branches       3009     3014       +5     
============================================
+ Hits          21789    21819      +30     
+ Misses        10260    10231      -29     
+ Partials       1726     1723       -3     

Impacted Files	Coverage Δ
...eeper/ZookeeperClientServerRegisterRepository.java	91.66% <75.00%> (+2.47%)	⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[loongs-zhang]

need impl offline for ZookeeperClientRegisterRepository.

[xuziyang]

need impl offline for ZookeeperClientRegisterRepository.

I believe that there is no need to implement the offline () method for the following reasons:

When the client side service stops, ShenyuClientShutdownHook will be triggered, which will close zkClient. After closing zkClient, the registered URI information will naturally be deleted by zk, and shenyu admin can sense the offline of the service.

[loongs-zhang]

I saw the org.apache.shenyu.register.client.zookeeper.ZookeeperClientRegisterRepository#registerURI, you are correct.